Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lwjgl3 final tweak #4216

Merged
merged 52 commits into from Oct 24, 2020
Merged

Lwjgl3 final tweak #4216

merged 52 commits into from Oct 24, 2020

Conversation

Cervator
Copy link
Member

@Cervator Cervator commented Oct 24, 2020

Builds one more quick commit on top of #3969. No, I'm totally not fishing for an easy PR for Hacktoberfest rather than seeing if I can just push to DarkWeird's branch, why do you ask? ;-)

Mac testing showed a few quirks but none that block this merge at long last.

  • Window focus on my Mac was weird - sometimes the game window would pop to the front of the screen without having focus, and I wouldn't be able to click it without first activating a different window then going back to the game window.
  • For some reason my Mac would end up with debug logging enabled by default, while Windows did not
  • Headless server starting on my Mac got the mad spam with "LocalChunkProvider - Compacting cache" we've seen in tests - probably since debug logging is enabled and that always happens, not just in unit tests that maybe also coincidentally get debug logging enabled. Rather than necessarily remove it outright (like in chore(chunkprovider): Streamline ChunkProvier #4214?) I wonder why we are even compacting the chunk cache every single tick? That seems like maybe a thing we could do once per second or even more rarely

Only commit that matters (right now anyway) is 930a664

…tect. otherwise System.setProperty haven't any effect on Lwjgl Configuration.
…independ (it can break writing lwjgl's path natives)
# Conflicts:
#	engine/src/main/java/org/terasology/engine/subsystem/lwjgl/LwjglGraphics.java
#	engine/src/main/java/org/terasology/rendering/ShaderManagerLwjgl.java
# Conflicts:
#	engine/src/main/java/org/terasology/rendering/cameras/OpenVRStereoCamera.java
#	engine/src/main/java/org/terasology/rendering/cameras/PerspectiveCamera.java
…stem and NUI.

Input system and NUI have separate *Char(Event,Action) for text input now.
UIWidget have onCharInput method now.
All Key actions and events haven't inputCharacter(text) now. only raw keys.
DarkWeird and others added 22 commits July 28, 2020 21:16
# Conflicts:
#	engine/src/main/java/org/terasology/rendering/cameras/OpenVRStereoCamera.java
#	engine/src/main/java/org/terasology/rendering/cameras/OrthographicCamera.java
#	engine/src/main/java/org/terasology/rendering/cameras/PerspectiveCamera.java
# Conflicts:
#	engine/build.gradle
#	engine/src/main/java/org/terasology/rendering/backdrop/Skysphere.java
#	engine/src/main/java/org/terasology/rendering/nui/CoreLayout.java
#	engine/src/main/java/org/terasology/rendering/nui/CoreScreenLayer.java
#	engine/src/main/java/org/terasology/rendering/nui/CoreWidget.java
#	engine/src/main/java/org/terasology/rendering/nui/UIWidget.java
#	engine/src/main/java/org/terasology/rendering/nui/events/NUIKeyEvent.java
#	engine/src/main/java/org/terasology/rendering/nui/internal/LwjglCanvasRenderer.java
#	engine/src/main/java/org/terasology/rendering/nui/internal/NUIManagerInternal.java
#	engine/src/main/java/org/terasology/rendering/nui/widgets/UIText.java
#	facades/PC/src/main/java/org/terasology/engine/Terasology.java
# Conflicts:
#	engine/build.gradle
#	engine/src/main/java/org/terasology/engine/subsystem/lwjgl/BaseLwjglSubsystem.java
#	engine/src/main/java/org/terasology/engine/subsystem/lwjgl/LwjglGraphics.java
#	engine/src/main/java/org/terasology/utilities/LWJGLHelper.java
#	facades/PC/build.gradle
# Conflicts:
#	facades/PC/build.gradle
…pendencies. Seems, broken after upgrading gradle to version 6.7
@Cervator Cervator merged commit 930a664 into MovingBlocks:develop Oct 24, 2020
@Cervator Cervator added this to the v4.1.0 milestone Oct 24, 2020
@Cervator Cervator deleted the lwjgl3Final branch November 8, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants