Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Archive COLLADA format #4227

Merged
merged 1 commit into from Oct 31, 2020

Conversation

Cervator
Copy link
Member

See https://trello.com/c/Xj9Iks10/41-consider-reviving-collada-format - in short COLLADA was never quite finished and never used and now with glTF in place we're trying to clean up.

I checked with @mkienenb who originally contributed the format (and many other things of both esoteric and useful flavors!) and it was nice to hear a sign of life, but yeah this isn't useful right now and isn't likely to be revived in the near future. I still prepared a Trello backlog card for it and will point at this PR in case anybody some day wants to revive the support. Juuuust in case since I do dislike losing potentially useful stuff. This way we can say we've just parked the code on a nice comfy farm somewhere up the river where it can live happily in retirement until called upon again.

I think I got all the related files and nothing should be affected by this going missing. Did some assorted spot testing with no obvious problems.

@Cervator Cervator added Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc. Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Topic: Rendering Requests, Issues and Changes related to lighting, meshes, camera, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness labels Oct 31, 2020
Copy link
Member

@skaldarnar skaldarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skaldarnar skaldarnar added this to the v4.1.0 milestone Oct 31, 2020
@skaldarnar skaldarnar changed the title Archive COLLADA format chore: Archive COLLADA format Oct 31, 2020
@skaldarnar skaldarnar merged commit 83703a5 into MovingBlocks:develop Oct 31, 2020
@Cervator Cervator deleted the archiveCollada branch November 1, 2020 02:19
@Cervator
Copy link
Member Author

Cervator commented Nov 1, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Build/CI Requests, Issues and Changes targeting gradle, groovy, Jenkins, etc. Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc. Topic: Rendering Requests, Issues and Changes related to lighting, meshes, camera, etc. Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants