chore: change texture file for 'engine:gui' atlas (crosshair-only) #4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
added
the
Topic: UI/UX
DarkWeird
approved these changes
Nov 3, 2020
| "tileNames": [ | ||
| "crosshair", "crosshairCharge1", "crosshairCharge2", "crosshairCharge3", "crosshairCharge4", | ||
| "crosshairCharge5", "crosshairCharge6", "crosshairCharge7", "crosshairCharge8" | ||
| "crosshairCharge5", "crosshairCharge6", "crosshairCharge7", "crosshairCharge8", "" |
There was a problem hiding this comment.
why we have empty tileName?
There was a problem hiding this comment.
Because I made the texture file 220x22 with 10 tiles... I could also go for 198x22 and have only 9 tiles 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4180 , but does not fix it.
Most parts of the old
gui.pngwere not used at all, so I'm moving the crosshair part into a smaller texture file only containing crosshair-related textures.You can still see the artefact on the left of the charge bar (red pixels).