Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not killed process. #4241

Merged
merged 1 commit into from Nov 9, 2020
Merged

Fix not killed process. #4241

merged 1 commit into from Nov 9, 2020

Conversation

DarkWeird
Copy link
Contributor

Contains

Fixes #4240

How to test

  1. Run game
  2. create/load world
  3. Exit from TS.
  4. Game process should finished.

@DarkWeird DarkWeird added the Type: Bug Issues reporting and PRs fixing problems label Nov 9, 2020
skaldarnar
skaldarnar approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@skaldarnar skaldarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my Linux Mint, works fine!

@skaldarnar skaldarnar added this to the v4.1.0 milestone Nov 9, 2020
@skaldarnar skaldarnar merged commit 02e6de7 into develop Nov 9, 2020
@skaldarnar skaldarnar deleted the fix/non-daemon-thread branch November 9, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skaldarnar skaldarnar skaldarnar approved these changes

@keturn keturn Awaiting requested review from keturn

@jdrueckert jdrueckert Awaiting requested review from jdrueckert

Assignees
No one assigned
Labels
Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.

Game process does not finish
2 participants
@DarkWeird @skaldarnar