fix: remove afk screen #4248
Merged
fix: remove afk screen #4248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
requested changes
Nov 14, 2020
engine/src/main/java/org/terasology/logic/afk/AfkClientSystem.java
Outdated
Show resolved
Hide resolved
| enableDiscord(); | ||
| console.addMessage("[AFK] You are AFK now!"); | ||
| logger.info("[AFK] You are AFK now!"); |
There was a problem hiding this comment.
I think some form of confirmation would be nice... Console is the text box in the bottom left, right? I think we could also print to the dev console by returning a String from this command method.
| disableDiscord(); | ||
| console.addMessage("[AFK] You are no longer AFK!"); | ||
| logger.info("[AFK] You are no longer AFK!"); |
There was a problem hiding this comment.
Same here, application logs are not visible to the player.
…java Co-authored-by: Tobias Nett <skaldarnar@googlemail.com>
…logy into feature/remove-afk-screen
skaldarnar
previously approved these changes
Nov 14, 2020
…logy into feature/remove-afk-screen
|
Closes #4243 |
|
is there any other changes we want to make @skaldarnar. |
skaldarnar
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed the afk screen and moved the console messages to logging instead. having an popup show up every minute or so is kind of obnoxious. probably just enough to mark the player as afk rather then also notify them that they are afk. I don't think there is really a need to convey this to player in the first place. in single player this popup shows up constantly so that needs to be addressed as well. it would need to be disabled in singe player since afk is not really relevant in this case. mostly to signal other players that the given player is not available to interact with.
ref: #3571