Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(JOML): remove legacy typeHandlers #4478

Merged

Conversation

pollend
Copy link
Member

@pollend pollend commented Feb 7, 2021

This drops all the typehandlers for termath. the tests are migrated over in this PR (#4474)

@skaldarnar
Copy link
Member

Is it safe to remove them already? Or would this break stuff as long as we still use those types?

@DarkWeird any opinion on that?

@skaldarnar skaldarnar added this to the v4.2.0 milestone Feb 7, 2021
@DarkWeird
Copy link
Contributor

Is it safe to remove them already? Or would this break stuff as long as we still use those types?

@DarkWeird any opinion on that?

It will break already serialized data.(old world loading, server-client connection if different versions)

Serialization will use default class serialization for legacy tera math

@skaldarnar
Copy link
Member

It will break already serialized data.(old world loading, server-client connection if different versions)

I think this is only true if we would try to load the data as legacy types, right? I think we have new type handlers for JOML that will be able to parse the data into the new types just fine (which should allow to even load old worlds 🤔 )

Anyways, we don't guarantee that our worlds are compatible between releases... 🙈

@jdrueckert jdrueckert merged commit 3231033 into MovingBlocks:develop Feb 8, 2021
@pollend pollend deleted the feat/joml-remove-legacy-type-handlers branch February 13, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants