refactor(ModuleManager): factor initiliaztion code to multiple methods #4540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keturn
commented
Feb 23, 2021
| @@ -79,16 +79,20 @@ public ModuleManager(String masterServerAddress, List<Class<?>> classesOnClasspa | |||
|
|
|||
| loadModulesFromApplicationPath(pathManager); | |||
|
|
|||
| ensureModulesDependOnEngine(engineModule); | |||
There was a problem hiding this comment.
I wondered why this is important, and found #1450
It's not a worry that the engine module wouldn't be loaded without it. It's about ordering: some things run in an order derived from the dependency tree, and we want to make sure engine is at the root of it.
There was a problem hiding this comment.
Added this as comment to ensureModulesDependOnEngine for later reference.
skaldarnar
added
the
Topic: Stabilization
skaldarnar
requested changes
Feb 23, 2021
engine/src/main/java/org/terasology/engine/module/ModuleManager.java
Outdated
Show resolved
Hide resolved
| @@ -79,16 +79,20 @@ public ModuleManager(String masterServerAddress, List<Class<?>> classesOnClasspa | |||
|
|
|||
| loadModulesFromApplicationPath(pathManager); | |||
|
|
|||
| ensureModulesDependOnEngine(engineModule); | |||
There was a problem hiding this comment.
Added this as comment to ensureModulesDependOnEngine for later reference.
skaldarnar
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring in anticipation of changes for gestalt v7.
I think these are all strict refactors, minimal testing required.
Open to feedback about where these methods should be ordered in the class file.
Outstanding before merging