refactor(translation): use ResourceUrn instead of SimpleUrn
#4931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Refactoring
jdrueckert
requested changes
Oct 30, 2021
There was a problem hiding this comment.
@DarkWeird I'm wondering whether we should rename variables currently called uri to urn instead
engine/src/main/java/org/terasology/engine/i18n/assets/TranslationData.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/terasology/engine/i18n/TranslationSystemImpl.java
Outdated
Show resolved
Hide resolved
…tionData.java Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
…temImpl.java Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
@DarkWeird I think a refactor in intellij might've been easier than just merging the suggestions 🙈 |
jdrueckert
approved these changes
Oct 30, 2021
There was a problem hiding this comment.
@DarkWeird I took the liberty of just doing the remaining renamings 🙂
jdrueckert
changed the title
ResourceUrn instead SimpleUrnResourceUrn instead of SimpleUrn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
Prepare to extract I18n as Subsystem.
Part of #4304.
It required for extract AutoConfig.
How to test