Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Chunk): provide default implementations of methods where possible #4989

Merged
merged 1 commit into from Jan 22, 2022
Merged

refactor(Chunk): provide default implementations of methods where possible #4989

merged 1 commit into from Jan 22, 2022

Conversation

keturn
Copy link
Member

@keturn keturn commented Jan 21, 2022

I cherry-picked this refactoring out of #4987.

This PR isn't blocking, but merging it now will make other work in the area easier to review.

@keturn keturn added Size: S Small effort likely only affecting a single area and requiring little to no research Topic: WorldGen Requests, Issues and Changes related to facets, rasterizers, etc. Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity labels Jan 21, 2022
@keturn keturn merged commit edecd07 into develop Jan 22, 2022
@keturn keturn deleted the refactor/chunkdefaultmethods branch January 22, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skaldarnar skaldarnar skaldarnar approved these changes

Assignees
No one assigned
Labels
Size: S Small effort likely only affecting a single area and requiring little to no research Topic: WorldGen Requests, Issues and Changes related to facets, rasterizers, etc. Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@keturn @skaldarnar