Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: merge spawn preview screen into world pre generation screen #5118

Merged
merged 3 commits into from
Jul 20, 2023
Merged

refactor: merge spawn preview screen into world pre generation screen #5118

merged 3 commits into from
Jul 20, 2023

Conversation

jdrueckert
Copy link
Member

@jdrueckert jdrueckert commented Jul 13, 2023 •
edited by skaldarnar

Contains

Merges the screens involved in the advanced game setup, in particular the world setup.

How to test

  1. Start Terasology
  2. Go through Advanced Game Setup
  3. Check that world can still be started fine
  4. Play around with the UI elements to check that there's no crashes or weirdness

Outstanding before merging

  • merge spawn preview screen into world pre generation screen

Follow-ups

  • merge universe setup screen into world pre generation screen
  • merge world setup screen into world pre generation screen
  • rename world pre generation screen

@jdrueckert jdrueckert added Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity labels Jul 13, 2023
@jdrueckert jdrueckert added this to the 2023 Revive - Milestone 1 milestone Jul 13, 2023
@jdrueckert jdrueckert changed the base branch from develop to refactor/remove-multi-world July 16, 2023 20:15
Base automatically changed from refactor/remove-multi-world to develop July 17, 2023 19:14
@skaldarnar skaldarnar force-pushed the refactor/merge-advanced-world-setup-screens branch from 7e7d815 to fcf8723 Compare July 18, 2023 16:28
skaldarnar
skaldarnar previously approved these changes Jul 18, 2023
View reviewed changes
@skaldarnar skaldarnar changed the title refactor: merge advanced world setup screens refactor: merge spawn preview screen into world pre generation screen Jul 18, 2023
@skaldarnar skaldarnar mentioned this pull request Jul 18, 2023
Merged
11 tasks
@jdrueckert jdrueckert merged commit 9b863dd into develop Jul 20, 2023
10 checks passed
@jdrueckert jdrueckert deleted the refactor/merge-advanced-world-setup-screens branch July 20, 2023 21:05
@jdrueckert jdrueckert mentioned this pull request Mar 17, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skaldarnar skaldarnar skaldarnar approved these changes

Assignees

@skaldarnar skaldarnar

@jdrueckert jdrueckert

Labels
Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity
Projects
Revive Terasology
Status: Done
Milestone
2023 Revive - Milestone 1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jdrueckert @skaldarnar