chore: update JNBullet to 1.0.4 #5225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Chore
|
✅ tests out fine on M1 Mac (_I can build and start the game into the main menu, running the game crashes due to some OpenGL error. I think the Vulkan workstream had made some progress in that direction.) |
|
Tests out fine on Linux and Windows |
soloturn
force-pushed
the
chore/update-jnbullet
branch
from
3625fcb
to
7abf2d0
Compare
|
Everything should be ready for releasing JNBullet v1.0.4. It just needs a final non-snapshot release to be published now. |
soloturn
approved these changes
Apr 20, 2024
build.gradle.kts
Outdated
| @@ -98,7 +98,7 @@ dependencies { | |||
| natives(group = "org.terasology.jnlua", name = "jnlua_natives", version = "0.1.0-SNAPSHOT", ext = "zip") | |||
|
|
|||
| // Natives for JNBullet | |||
| natives(group = "org.terasology.jnbullet", name = "JNBullet", version = "1.0.2", ext = "zip") | |||
| natives(group = "org.terasology.jnbullet", name = "JNBullet", version = "1.0.4-SNAPSHOT", ext = "zip") | |||
There was a problem hiding this comment.
it would be better to have release versions not snapshot versions?
There was a problem hiding this comment.
that's exactly why the PR wasn't merged before and why I updated it with 496bdaf 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
With JNBullet v1.0.4(-SNAPSHOT) we bundle natives for both Intel and Apple Silicon Macs.
Nothing should change for Linux and Windows.
Related to MovingBlocks/JNBullet#15.
Contributes to #5055.
How to test
Just checkout this PR and run the game from source.
Outstanding before merging