fix(facades): fix command line args not working #5245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminAmos
approved these changes
May 9, 2024
Cervator
approved these changes
May 10, 2024
There was a problem hiding this comment.
Tested locally, fixes the bug! Will merge :-)
No need to change anything run config, since this just fixes the argument - earlier I wasn't sure if the name/format of the parameter changed, but now that I got a chance to look it is even easier.
Thanks for the fix (and the extra pair of eyes BSA) !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
fix for not working command line arg
How to test
launching the with no-sound
Outstanding before merging
nope