chore: merge BaseLauncherSettings into LauncherSettings #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For historic reasons, the launcher settings classes were split into an abstract class interface and (several) implementations, but we dropped most of those some time ago. Since we now only have single implementation class there's no point in keeping the interface and implementation separate.
|
Not yet ready for review - I'm playing around with switching the settings from |
skaldarnar
added
the
Type: Maintenance
7 tasks
jdrueckert
approved these changes
Sep 1, 2021
skaldarnar
added
the
Topic: Configuration
skaldarnar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains no semantic or functional changes.
Consider this part one of consolidating the launcher settings implementation.
For historic reasons, the launcher settings classes were split into an abstract class interface and (several) implementations, but we dropped most of those some time ago.
Since we now only have single implementation class there's no point in keeping the interface and implementation separate.
Working towards #522