New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve deployment process #749

Closed

alanmoo opened this issue Sep 12, 2017 · 6 comments

Assignees

Milestone

Oct 29, 2017 - Mo...

Contributor

alanmoo commented Sep 12, 2017

What problem(s) are we trying to solve?

Making changes to the network site is error-prone.
- There's a circular dependency in which the front end being built is dependent on the API being spun up, but that doesn't happen till the front end gets built.
- Deploying changes is error prone- sometimes rebuilds fail silently on content updates
- Production/Master branch setup is unlike our other projects, and it's helpful to have the same dev/deploy process as much as possible.

We need to solve these, keeping in mind that Mezzanine templating...isn't great or easy

(original etherpad)

alanmoo added this to the Sept 22, 2017 milestone

alanmoo assigned Pomax, gvn, cadecairos and alanmoo

alanmoo added the Epic label

xmatthewx modified the milestones: Sept 22, 2017, Oct 6, 2017

Contributor Author

alanmoo commented Sep 26, 2017

Before closing this we're going to need to turn off the "rebuild on model change" script @cadecairos

cadecairos commented Sep 26, 2017

@alanmoo is this something we want now? I can disable it via config, and I can rip out the signals altogether.

Contributor

gvn commented Sep 26, 2017

Should be safe to turn off now that all the CMS driven components are pulling via XHR on prod.

cadecairos mentioned this issue

Remove Signals for building using the Heroku Build API #798

Closed

cadecairos commented Sep 26, 2017

filed #798 - I think I might leave that for next week, and just disable the build via config for now

cadecairos commented Sep 27, 2017

The model signals will now bail early, as I've unset the config vars they rely on.

xmatthewx modified the milestones: Oct 6, 2017, Oct 20, 2017 - Road to MozFest, Oct 29, 2017 - MozFest

Contributor Author

alanmoo commented Oct 25, 2017

Closing epic, final issue has a PR open.

alanmoo closed this as completed

gvn pushed a commit that referenced this issue


          Bump shelljs from 0.7.8 to 0.8.2 (#1780)

49304f9

Bumps [shelljs](https://github.com/shelljs/shelljs) from 0.7.8 to 0.8.2.
<details>
<summary>Release notes</summary>

*Sourced from [shelljs's releases](https://github.com/shelljs/shelljs/releases).*

> ## v0.8.1
> **Closed issues:**
> 
> - Exec failing with internal error when piping large output [\[#818](https://github-redirect.dependabot.com/shelljs/shelljs/issues/818)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/818)
> - using sed to replace just the first occurrence of a string [\[#813](https://github-redirect.dependabot.com/shelljs/shelljs/issues/813)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/813)
> 
> **Merged pull requests:**
> 
> - Revert "refactor\(exec\): remove paramsFile \(\#807\)" [\[#819](https://github-redirect.dependabot.com/shelljs/shelljs/issues/819)](https://github-redirect.dependabot.com/shelljs/shelljs/pull/819) ([nfischer](https://github.com/nfischer))
> 
> ## v0.8.0
> **Closed issues:**
> 
> - Snyk vulnerability DB reporting command injection vulnerability in ShellJS [\[#810](https://github-redirect.dependabot.com/shelljs/shelljs/issues/810)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/810)
> - chore: upgrade nyc [\[#803](https://github-redirect.dependabot.com/shelljs/shelljs/issues/803)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/803)
> - Update CI to use Node v9 [\[#799](https://github-redirect.dependabot.com/shelljs/shelljs/issues/799)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/799)
> - Link to FAQ wiki section in our issue template [\[#787](https://github-redirect.dependabot.com/shelljs/shelljs/issues/787)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/787)
> - Is it possible to get a js library\(file\) for ShellJS [\[#776](https://github-redirect.dependabot.com/shelljs/shelljs/issues/776)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/776)
> - 48, [\[#774](https://github-redirect.dependabot.com/shelljs/shelljs/issues/774)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/774)
> - 47 [\[#773](https://github-redirect.dependabot.com/shelljs/shelljs/issues/773)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/773)
> - Exec function calls JSON.stringify on command [\[#772](https://github-redirect.dependabot.com/shelljs/shelljs/issues/772)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/772)
> - getting different result from terminal and with shelljs  [\[#769](https://github-redirect.dependabot.com/shelljs/shelljs/issues/769)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/769)
> - test\(\) does not support -w and -x options [\[#768](https://github-redirect.dependabot.com/shelljs/shelljs/issues/768)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/768)
> - Snyk "high severity" issue [\[#766](https://github-redirect.dependabot.com/shelljs/shelljs/issues/766)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/766)
> - Snyk "high security [\[#765](https://github-redirect.dependabot.com/shelljs/shelljs/issues/765)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/765)
> - ShellJS doesn't respect NPM Registry being set outside of it [\[#761](https://github-redirect.dependabot.com/shelljs/shelljs/issues/761)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/761)
> - Run second shell script [\[#756](https://github-redirect.dependabot.com/shelljs/shelljs/issues/756)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/756)
> - shelljs seems NOT compatible with nexe under CentOS 6.5 [\[#754](https://github-redirect.dependabot.com/shelljs/shelljs/issues/754)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/754)
> - Feature request: pushd/popd -q option [\[#753](https://github-redirect.dependabot.com/shelljs/shelljs/issues/753)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/753)
> - cat doesn't support '-n' option [\[#750](https://github-redirect.dependabot.com/shelljs/shelljs/issues/750)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/750)
> - shelljs run xcodebuild error [\[#749](https://github-redirect.dependabot.com/shelljs/shelljs/issues/749)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/749)
> - Add wrappers around fs.statSync and fs.lstatSync [\[#745](https://github-redirect.dependabot.com/shelljs/shelljs/issues/745)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/745)
> - Improve coverage for exec\(\) [\[#742](https://github-redirect.dependabot.com/shelljs/shelljs/issues/742)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/742)
> - Improve coverage for head\(\) [\[#741](https://github-redirect.dependabot.com/shelljs/shelljs/issues/741)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/741)
> - shelljs is no longer used in PDF.js [\[#737](https://github-redirect.dependabot.com/shelljs/shelljs/issues/737)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/737)
> - ls doesn't follow links to directories [\[#733](https://github-redirect.dependabot.com/shelljs/shelljs/issues/733)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/733)
> - Add test for `ls regular-file.txt` [\[#732](https://github-redirect.dependabot.com/shelljs/shelljs/issues/732)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/732)
> - shelljs.exec hangs when password it's asked [\[#716](https://github-redirect.dependabot.com/shelljs/shelljs/issues/716)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/716)
> - Clean up common tests [\[#714](https://github-redirect.dependabot.com/shelljs/shelljs/issues/714)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/714)
> - Can't run docker with exec\(\) \(the input device is not a TTY\) [\[#680](https://github-redirect.dependabot.com/shelljs/shelljs/issues/680)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/680)
> - Cant get encoding buffer to work on exec [\[#675](https://github-redirect.dependabot.com/shelljs/shelljs/issues/675)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/675)
> - Set up Codecov for the project [\[#671](https://github-redirect.dependabot.com/shelljs/shelljs/issues/671)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/671)
> - ShellJS: internal error Error: EBUSY: resource busy or locked, lstat 'C:\pagefile.sys' [\[#514](https://github-redirect.dependabot.com/shelljs/shelljs/issues/514)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/514)
> - Feature request: provide a way to skip option parsing [\[#778](https://github-redirect.dependabot.com/shelljs/shelljs/issues/778)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/778)
> - Switch to os.homedir\(\) when we move to v4+ [\[#683](https://github-redirect.dependabot.com/shelljs/shelljs/issues/683)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/683)
> - Drop support for v0.12 [\[#647](https://github-redirect.dependabot.com/shelljs/shelljs/issues/647)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/647)
> - feature: echo -n [\[#559](https://github-redirect.dependabot.com/shelljs/shelljs/issues/559)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/559)
> - Don't kill the node process upon unexpected error [\[#483](https://github-redirect.dependabot.com/shelljs/shelljs/issues/483)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/483)
> - Echo doesn't return value ending in a trailing newline [\[#476](https://github-redirect.dependabot.com/shelljs/shelljs/issues/476)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/476)
> - Synchronous exec stalls permenantly when there is an error/w the shell [\[#7](https://github-redirect.dependabot.com/shelljs/shelljs/issues/7)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/7)
></table> ... (truncated)
</details>
<details>
<summary>Changelog</summary>

*Sourced from [shelljs's changelog](https://github.com/shelljs/shelljs/blob/master/CHANGELOG.md).*

> ## [v0.8.2](https://github.com/shelljs/shelljs/tree/v0.8.2) (2018-05-08)
> [Full Changelog](shelljs/shelljs@v0.8.1...v0.8.2)
> 
> **Closed issues:**
> 
> - High severity vulnerability in shelljs 0.8.1 [\[#842](https://github-redirect.dependabot.com/shelljs/shelljs/issues/842)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/842)
> - Add test for ls\(\) on a symlink to a directory [\[#795](https://github-redirect.dependabot.com/shelljs/shelljs/issues/795)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/795)
> - Harden shell.exec by writing the child process in a source file [\[#782](https://github-redirect.dependabot.com/shelljs/shelljs/issues/782)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/782)
> - shell.exec\(\) doesn't respond correctly to config.fatal = true [\[#735](https://github-redirect.dependabot.com/shelljs/shelljs/issues/735)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/735)
> - Merge 'exec: internal error' with ShellJSInternalError [\[#734](https://github-redirect.dependabot.com/shelljs/shelljs/issues/734)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/734)
> - exec returning null from command [\[#724](https://github-redirect.dependabot.com/shelljs/shelljs/issues/724)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/724)
> - Only Get Stderr from Exec [\[#371](https://github-redirect.dependabot.com/shelljs/shelljs/issues/371)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/371)
> - Execute child.stdout.on before child.on\("exit"\)  [\[#224](https://github-redirect.dependabot.com/shelljs/shelljs/issues/224)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/224)
> 
> **Merged pull requests:**
> 
> - Workaround codecov bug of miscalculation of coverage \(\#795\) [\[#838](https://github-redirect.dependabot.com/shelljs/shelljs/issues/838)](https://github-redirect.dependabot.com/shelljs/shelljs/pull/838) ([dwi2](https://github.com/dwi2))
> - Update doc comments and regenerate README.md. [\[#825](https://github-redirect.dependabot.com/shelljs/shelljs/issues/825)](https://github-redirect.dependabot.com/shelljs/shelljs/pull/825) ([Zearin](https://github.com/Zearin))
> - chore: update contributing guidelines [\[#817](https://github-redirect.dependabot.com/shelljs/shelljs/issues/817)](https://github-redirect.dependabot.com/shelljs/shelljs/pull/817) ([nfischer](https://github.com/nfischer))
> - chore\(lint\): don't allow excess trailing newlines [\[#816](https://github-redirect.dependabot.com/shelljs/shelljs/issues/816)](https://github-redirect.dependabot.com/shelljs/shelljs/pull/816) ([nfischer](https://github.com/nfischer))
> - Remove separate "internal error" from exec [\[#802](https://github-redirect.dependabot.com/shelljs/shelljs/issues/802)](https://github-redirect.dependabot.com/shelljs/shelljs/pull/802) ([freitagbr](https://github.com/freitagbr))
> 
> ## [v0.8.1](https://github.com/shelljs/shelljs/tree/v0.8.1) (2018-01-20)
> [Full Changelog](shelljs/shelljs@v0.8.0...v0.8.1)
> 
> **Closed issues:**
> 
> - Exec failing with internal error when piping large output [\[#818](https://github-redirect.dependabot.com/shelljs/shelljs/issues/818)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/818)
> - using sed to replace just the first occurrence of a string [\[#813](https://github-redirect.dependabot.com/shelljs/shelljs/issues/813)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/813)
> 
> **Merged pull requests:**
> 
> - Revert "refactor\(exec\): remove paramsFile \(\#807\)" [\[#819](https://github-redirect.dependabot.com/shelljs/shelljs/issues/819)](https://github-redirect.dependabot.com/shelljs/shelljs/pull/819) ([nfischer](https://github.com/nfischer))
> 
> ## [v0.8.0](https://github.com/shelljs/shelljs/tree/v0.8.0) (2018-01-12)
> [Full Changelog](shelljs/shelljs@v0.7.8...v0.8.0)
> 
> **Closed issues:**
> 
> - Snyk vulnerability DB reporting command injection vulnerability in ShellJS [\[#810](https://github-redirect.dependabot.com/shelljs/shelljs/issues/810)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/810)
> - chore: upgrade nyc [\[#803](https://github-redirect.dependabot.com/shelljs/shelljs/issues/803)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/803)
> - Update CI to use Node v9 [\[#799](https://github-redirect.dependabot.com/shelljs/shelljs/issues/799)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/799)
> - Link to FAQ wiki section in our issue template [\[#787](https://github-redirect.dependabot.com/shelljs/shelljs/issues/787)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/787)
> - Is it possible to get a js library\(file\) for ShellJS [\[#776](https://github-redirect.dependabot.com/shelljs/shelljs/issues/776)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/776)
> - 48, [\[#774](https://github-redirect.dependabot.com/shelljs/shelljs/issues/774)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/774)
> - 47 [\[#773](https://github-redirect.dependabot.com/shelljs/shelljs/issues/773)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/773)
> - Exec function calls JSON.stringify on command [\[#772](https://github-redirect.dependabot.com/shelljs/shelljs/issues/772)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/772)
> - getting different result from terminal and with shelljs  [\[#769](https://github-redirect.dependabot.com/shelljs/shelljs/issues/769)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/769)
> - test\(\) does not support -w and -x options [\[#768](https://github-redirect.dependabot.com/shelljs/shelljs/issues/768)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/768)
> - Snyk "high severity" issue [\[#766](https://github-redirect.dependabot.com/shelljs/shelljs/issues/766)](https://github-redirect.dependabot.com/shelljs/shelljs/issues/766)
></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- [`3b266d0`](shelljs/shelljs@3b266d0) 0.8.2
- [`3ce805e`](shelljs/shelljs@3ce805e) docs(changelog): updated by Nate Fischer [ci skip]
- [`d7b6a1f`](shelljs/shelljs@d7b6a1f) Workaround codecov bug of miscalculation of coverage ([#795](https://github-redirect.dependabot.com/shelljs/shelljs/issues/795)) ([#838](https://github-redirect.dependabot.com/shelljs/shelljs/issues/838))
- [`9035b27`](shelljs/shelljs@9035b27) docs: fix typos and adjust markdown formatting ([#825](https://github-redirect.dependabot.com/shelljs/shelljs/issues/825))
- [`9077f41`](shelljs/shelljs@9077f41) Remove separate "internal error" from exec ([#802](https://github-redirect.dependabot.com/shelljs/shelljs/issues/802))
- [`62ce4ba`](shelljs/shelljs@62ce4ba) chore(lint): don't allow excess trailing newlines ([#816](https://github-redirect.dependabot.com/shelljs/shelljs/issues/816))
- [`2271080`](shelljs/shelljs@2271080) chore: update contributing guidelines ([#817](https://github-redirect.dependabot.com/shelljs/shelljs/issues/817))
- [`bbcfa5c`](shelljs/shelljs@bbcfa5c) docs(changelog): updated by Nate Fischer [ci skip]
- [`7058d63`](shelljs/shelljs@7058d63) 0.8.1
- [`cb9cf27`](shelljs/shelljs@cb9cf27) Revert "refactor(exec): remove paramsFile ([#807](https://github-redirect.dependabot.com/shelljs/shelljs/issues/807))" ([#819](https://github-redirect.dependabot.com/shelljs/shelljs/issues/819))
- Additional commits viewable in [compare view](shelljs/shelljs@v0.7.8...v0.8.2)
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=shelljs&package-manager=npm_and_yarn&previous-version=0.7.8&new-version=0.8.2)](https://dependabot.com/compatibility-score.html?dependency-name=shelljs&package-manager=npm_and_yarn&previous-version=0.7.8&new-version=0.8.2)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment