7441 category share data

[danielfmiranda]

Closes #7441
Related PRs/issues #

Link to sample test page: https://foundation-s-7441-categ-8ryjva.herokuapp.com/en/privacynotincluded/categories/health-exercise/

Expected Results:

Steps to test:

1. For testing purposes, I have added a custom image to the "Health And Exercise" category on the staging app already. If you would like to upload a picture yourself in the CMS for a category, please feel free to do so!
2. Visit the page above, which is the Entertainment category PNI page
3. Copy and paste the URL and send it through slack, or the other platform of your choice.
4. If the preview for the page looks like the picture above, testing is complete!

Checklist

Changes in Models:

• [Are my changes backward-compatible]

[TheoChevalier]

I know this is still marked as WIP, but wanted to flag early that we will want to make this work for localized categories too.
I think relying on category.localized should work here?

[danielfmiranda]

Hi @TheoChevalier and @Pomax I have a quick question regarding localization.

I have added the feedback that Theo suggested, but noticed that on my local and test environment, I will receive a 500 error saying "Locale matching query does not exist."

Would there be a way to test this on the test environment?
I have tried to create a new locale category on the test environment but am unable to find the option to do so.

Also, I have implemented your feedback Theo, however I am unsure if I am using it correctly:

       if category.share_image:
            setattr(self, 'search_image_id', category.localized.share_image_id)
        if category.description:
            setattr(self, 'search_description', category.localized.description)

From my understanding, if the category has either of these things, then we want to set the metadata to the localised version?

Thanks in advance!

[kristinashu]

Hi @danielfmiranda, should this be working? When I click on https://foundation-s-7441-categ-8ryjva.herokuapp.com/en/privacynotincluded/categories/entertainment/, I see Server Error (500).

[danielfmiranda]

Hi @kristinashu! Sorry about that, the updated URL is now https://foundation-s-7441-categ-8ryjva.herokuapp.com/en/privacynotincluded/categories/health-exercise/. Thank you!

[kristinashu]

Thank you, this is working well!

[TheoChevalier]

Hi @TheoChevalier and @Pomax I have a quick question regarding localization.

I have added the feedback that Theo suggested, but noticed that on my local and test environment, I will receive a 500 error saying "Locale matching query does not exist."

Would there be a way to test this on the test environment? I have tried to create a new locale category on the test environment but am unable to find the option to do so.

Also, I have implemented your feedback Theo, however I am unsure if I am using it correctly:

       if category.share_image:
            setattr(self, 'search_image_id', category.localized.share_image_id)
        if category.description:
            setattr(self, 'search_description', category.localized.description)

From my understanding, if the category has either of these things, then we want to set the metadata to the localised version?

Thanks in advance!

Hey @danielfmiranda, thanks! Your code looks good, and I was able to test locally it works.
The 500 error is not due to this PR — after adding a locale in Settings > Locale, you need to run inv manage sync_locale_trees in order to create all the page + snippet aliases for the new locale.

To test in the review app you’d need to:

• Add a new locale in Settings > Locale, synced with English.
• Run python network-api/manage.py sync_locale_trees as an Heroku command
• Translate a product category snippet
• Edit the translation / override the image

[Pomax]

just one small note

[Pomax]

if we're adding explicit panels, we can hide this autogenerated field by simply omitting it from the panel list.

[danielfmiranda]

Thanks for the catch @Pomax! I have removed the "slug" field from the panels and re requested review