-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7441 category share data #7606
Merged
Merged
7441 category share data #7606
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6a47893
added new image field, then checking if we can use them for share data
bb96e74
comment
b7138be
migrations and Theo's localization feedback
d8e9b16
formatting
eed6d8e
Merge remote-tracking branch 'origin/pni-q3-2021' into 7441-category-…
d1966cc
updated migrations
a57d77b
localization of category share data
0bcf1c1
Merge branch 'pni-q3-2021' into 7441-category-share-data
danielfmiranda e0d0df2
Merge branch 'pni-q3-2021' into 7441-category-share-data
danielfmiranda 4ea0222
Merge branch 'pni-q3-2021' into 7441-category-share-data
danielfmiranda b46e19a
Removing slug from editable panels
danielfmiranda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
24 changes: 24 additions & 0 deletions
24
network-api/networkapi/wagtailpages/migrations/0044_auto_20211013_0018.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
# Generated by Django 3.1.11 on 2021-10-13 00:18 | ||
|
||
from django.db import migrations, models | ||
import django.db.models.deletion | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
('wagtailimages', '0023_add_choose_permissions'), | ||
('wagtailpages', '0043_auto_20211011_2340'), | ||
] | ||
|
||
operations = [ | ||
migrations.RemoveField( | ||
model_name='buyersguideproductcategory', | ||
name='og_image', | ||
), | ||
migrations.AddField( | ||
model_name='buyersguideproductcategory', | ||
name='share_image', | ||
field=models.ForeignKey(blank=True, help_text='Optional image that will apear when category page is shared.', null=True, on_delete=django.db.models.deletion.SET_NULL, to='wagtailimages.image', verbose_name='Share Image'), | ||
), | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we're adding explicit panels, we can hide this autogenerated field by simply omitting it from the panel list.