-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PNI] Search - update basic search behaviour #7649
Conversation
a1aec1e
to
cb460c9
Compare
Hm, interesting problem: it looks like search.js does not load until all images have loaded, which means you can't search for quite a while, particularly noticable when running a stage copy without S3 settings, which causes all product images to 404, and searchign doesn't work until all of those 404s have finished |
5c7e185
to
e1fea73
Compare
75834c2
to
c6c084c
Compare
network-api/networkapi/wagtailpages/templates/buyersguide/catalog.html
Outdated
Show resolved
Hide resolved
network-api/networkapi/wagtailpages/templates/fragments/no_search_results.html
Outdated
Show resolved
Hide resolved
18e693b
to
aeab95e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checkbox is remembered on Firefox too now 👍 Thanks for the update Simon!
@kristinashu that's intentional: searching doesn't change the URL you're on, but explicitly selecting a category does. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good as far as I can tell! some things we can iterate on, but let's file followup issues for that, for someone else to tackle in the future. I tested on the current stage copy using both en and fr locales and everything seemed to highlight correctly now.
fixing
73920a2
to
246b226
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me too now, just highlighted one potential issue
* 7475 - update basic search behaviour * 7476 - update search fields/ranking
* 7475 - update basic search behaviour * 7476 - update search fields/ranking
Closes #7475 #7476
keep product filtering, and make sure that categories are always listing all products, with out-of-category products hidden through CSS by default (Right now categories are prefiltered to only show in-category products)
When the user starts searching:
Sorting/ranking priority of the results:
No changes to design