load search when the page loads, rather than when react is done #7709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pomax
force-pushed
the
externalize-search
branch
from
1b10733
to
97ad8a4
Compare
Merged
|
Superceded by #7741 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7667
This updates the build so that search.js ends up as "its own file" in the frontend/js dir, getting loaded as part of the
<head>payload for catalog pages (PNI homepage + category pages) withasync deferso that it can be used as soon as the page DOM is ready for reading.Note that you'll want to hide whitespace for reviewing file changes in this case: https://github.com/mozilla/foundation.mozilla.org/pull/7709/files?diff=unified&w=1
Also note that this will need a "redo" for the search.js file itself, once #7649 has landed.
Test URL: https://foundation-s-externaliz-0hxqyx.herokuapp.com/en/privacynotincluded/