Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary slice copy in block iterator #74

Closed
MrCroxx opened this issue Mar 24, 2022 · 0 comments · Fixed by #75
Closed

Avoid unnecessary slice copy in block iterator #74

MrCroxx opened this issue Mar 24, 2022 · 0 comments · Fixed by #75
Assignees
@MrCroxx
Labels
enhancement New feature or request for optimization.

Comments

@MrCroxx
Copy link
Owner

MrCroxx commented Mar 24, 2022 •
edited

When porting block and block iterator from RunKV to RisingWave, found some unnecessary slice copy influenced the performance of block iterator a lot. We can also avoid them in RunKV.

For more detailes, see risingwave#1138.

Ref: #37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrCroxx MrCroxx

Labels
enhancement New feature or request for optimization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove unnecessary slice copy MrCroxx/RunKV
1 participant
@MrCroxx