Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: upgrade minitrace to reduce overhead #571

Merged
merged 2 commits into from
Jun 22, 2024
Merged

perf: upgrade minitrace to reduce overhead #571

merged 2 commits into from
Jun 22, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Jun 22, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title. Thank you, @andylokandy

Benchmark

disabled

Total:
disk total iops: 2782.5
disk total throughput: 515.0 MiB/s
disk read iops: 214.8
disk read throughput: 14.3 MiB/s
disk write iops: 2567.7
disk write throughput: 500.7 MiB/s
insert iops: 14264.5/s
insert throughput: 891.6 MiB/s
insert lat p50: 5us
insert lat p90: 9us
insert lat p99: 21us
insert lat p999: 246us
insert lat p9999: 413us
insert lat p99999: 551us
insert lat pmax: 631us
get iops: 29780.8/s
get miss: 46.81% 
get throughput: 1.0 GiB/s
get hit lat p50: 2us
get hit lat p90: 503us
get hit lat p99: 1391us
get hit lat p999: 2671us
get hit lat p9999: 3807us
get hit lat p99999: 5087us
get hit lat pmax: 5535us
get miss lat p50: 91us
get miss lat p90: 519us
get miss lat p99: 1327us
get miss lat p999: 2783us
get miss lat p9999: 3935us
get miss lat p99999: 4351us
get miss lat pmax: 4479us

enabled

Total:
disk total iops: 2736.1
disk total throughput: 510.8 MiB/s
disk read iops: 151.8
disk read throughput: 10.1 MiB/s
disk write iops: 2584.3
disk write throughput: 500.8 MiB/s
insert iops: 14252.2/s
insert throughput: 890.9 MiB/s
insert lat p50: 6us
insert lat p90: 11us
insert lat p99: 25us
insert lat p999: 61us
insert lat p9999: 319us
insert lat p99999: 579us
insert lat pmax: 1335us
get iops: 29077.9/s
get miss: 45.52% 
get throughput: 1.0 GiB/s
get hit lat p50: 6us
get hit lat p90: 461us
get hit lat p99: 1271us
get hit lat p999: 2127us
get hit lat p9999: 4351us
get hit lat p99999: 4447us
get hit lat pmax: 4511us
get miss lat p50: 125us
get miss lat p90: 519us
get miss lat p99: 1103us
get miss lat p999: 2287us
get miss lat p9999: 3871us
get miss lat p99999: 4671us
get miss lat pmax: 4831us

in one pic

image

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

tikv/minitrace-rust#224
#577

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx added the perf Performance optimization label Jun 22, 2024
@MrCroxx MrCroxx added this to the v0.9 milestone Jun 22, 2024
@MrCroxx MrCroxx self-assigned this Jun 22, 2024
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.46%. Comparing base (84445be) to head (d788f71).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
+ Coverage   86.41%   86.46%   +0.05%     
==========================================
  Files          59       59              
  Lines        7647     7647              
==========================================
+ Hits         6608     6612       +4     
+ Misses       1039     1035       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx enabled auto-merge (squash) June 22, 2024 08:17
@MrCroxx MrCroxx merged commit 626367b into main Jun 22, 2024
16 checks passed
@MrCroxx MrCroxx deleted the xx/umtrace branch June 22, 2024 08:22
@MrCroxx MrCroxx modified the milestones: v0.9, v0.10 Jun 24, 2024
@qRoC qRoC mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf Performance optimization
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant