Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use us instead of ns for tracing #582

Merged
merged 1 commit into from
Jun 25, 2024
Merged

refactor: use us instead of ns for tracing #582

merged 1 commit into from
Jun 25, 2024

Conversation

MrCroxx
Copy link
Collaborator

@MrCroxx MrCroxx commented Jun 25, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title. Why on earth I chose ns as default. = =

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#577

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx added this to the v0.10 milestone Jun 25, 2024
@MrCroxx MrCroxx self-assigned this Jun 25, 2024
@MrCroxx MrCroxx enabled auto-merge (squash) June 25, 2024 05:53
@MrCroxx MrCroxx merged commit f85e50b into main Jun 25, 2024
13 checks passed
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.20%. Comparing base (fe904bc) to head (aef1bf4).
Report is 1 commits behind head on main.

Files Patch % Lines
foyer-bench/src/main.rs 66.66% 5 Missing ⚠️
foyer/src/hybrid/cache.rs 72.72% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #582   +/-   ##
=======================================
  Coverage   86.20%   86.20%           
=======================================
  Files          59       59           
  Lines        7597     7597           
=======================================
  Hits         6549     6549           
  Misses       1048     1048           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCroxx MrCroxx deleted the xx/us branch June 25, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant