Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Settings Is Duplicated Instead Of Focused #104

Closed
2 tasks done
Soft-Bred opened this issue Nov 30, 2023 · 4 comments · Fixed by #109
Closed
2 tasks done

🐛 Settings Is Duplicated Instead Of Focused #104

Soft-Bred opened this issue Nov 30, 2023 · 4 comments · Fixed by #109
Assignees
Labels

Comments

@Soft-Bred
Copy link
Collaborator

Bug Description

When accessing the settings menu from the loop Menu Bar extension, a new Settings Menu is created, even if there is already an open Settings Menu. This should not happen. Instead, clicking on the settings button from the Menu Bar extension should focus any existing Settings Menus.

Steps To Reproduce

  1. Open Loop Menu Bar menu.
  2. Click ⌘,
  3. Repeat

Expected Behavior

Clicking on the Settings button from the Menu Bar extension should focus any existing Settings Menus.

Actual Behavior

Clicking on the Settings button from the Menu Bar extension creates a new Settings Menu, regardless if one is open already.

Screenshots

000741.mp4

MacOS Version

14.1.1 (23B81)

Loop Version

1.0.0-beta.12 (515)

Additional Context

No response

Final Checks

  • My issue title is descriptive
  • This is a single bug (multiple bugs should be reported individually)
@Soft-Bred Soft-Bred added the Bug label Nov 30, 2023
@MrKai77 MrKai77 self-assigned this Nov 30, 2023
@MrKai77
Copy link
Owner

MrKai77 commented Nov 30, 2023

I can reproduce that bug here. This seems to be a problem with the Settings package I use for Loop. Before this, there was also #80, and now there's this issue and also #92, which are all issues with the settings package.
Looks like the best option here might be to just make my own settings window using SwiftUI, since I already know that that will fix both this and the other issue.

MrKai77 added a commit that referenced this issue Dec 1, 2023
MrKai77 added a commit that referenced this issue Dec 1, 2023
@MrKai77
Copy link
Owner

MrKai77 commented Dec 1, 2023

Alright, there's the latest build with this issue fixed!
Loop.zip

@MrKai77
Copy link
Owner

MrKai77 commented Dec 1, 2023

Actually, here's the latest build 😅:
Loop.zip

@Soft-Bred
Copy link
Collaborator Author

Works :)

@MrKai77 MrKai77 linked a pull request Dec 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants