Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Settings toolbar items maintain active state on lost focus #80

Closed
2 tasks done
Zabriskije opened this issue Oct 29, 2023 · 5 comments · Fixed by #91
Closed
2 tasks done

🐛 Settings toolbar items maintain active state on lost focus #80

Zabriskije opened this issue Oct 29, 2023 · 5 comments · Fixed by #91
Assignees
Labels

Comments

@Zabriskije
Copy link
Contributor

Bug Description

Previously selected menu items remain highlighted until hovered again.

Steps To Reproduce

  1. Open Settings
  2. Select a menu item that isn't the current one

Expected Behavior

The previous menu item should lose highlighting.

Actual Behavior

The previous menu item remain highlighted.

Screenshots

Menu items maintain active state on lost focus

MacOS Version

Sonoma 14.0 (23A344)

Loop Version

1.0.0-beta.11 (465)

Additional Context

Also tested in beta.10 and seems to work as expected there.

Hope the title makes sense, I don't know if I'm using the right words :P

Final Checks

  • My issue title is descriptive
  • This is a single bug (multiple bugs should be reported individually)
@Zabriskije Zabriskije added the Bug label Oct 29, 2023
@MrKai77
Copy link
Owner

MrKai77 commented Oct 30, 2023

I can reproduce this as well. This seems to be an issue with the package I use to make the settings window (which is used ever since 1.0.0-beta.11).
They seemed to have fixed it here, so hopefully updating the package in Loop should fix it (it's currently on 3.0.3 whereas the latest version is 3.0.5)!

@MrKai77
Copy link
Owner

MrKai77 commented Oct 30, 2023

Setting the version to 3.0.5 seems to have mostly fixed it! But I can still reproduce it around once every 10 times. So I think that moving away from using the Settings package and making the settings window myself is the way to go. This should be pretty easy since that's how it was before 1.0.0-beta.11!

@MrKai77 MrKai77 changed the title 🐛 Menu items maintain active state on lost focus 🐛 Settings toolbar items maintain active state on lost focus Oct 30, 2023
MrKai77 added a commit that referenced this issue Nov 28, 2023
@MrKai77
Copy link
Owner

MrKai77 commented Nov 28, 2023

UPDATE: I noticed that after updating to 3.1.0, this doesn't happen anymore (and if it does, if force-redraws the toolbar to make it inactive again), so this bug is now non-existent!

MrKai77 added a commit that referenced this issue Nov 28, 2023
…state-on-lost-focus`

🐛 #80 Settings toolbar items maintain active state on lost focus
@Zabriskije
Copy link
Contributor Author

The black line under the toolbar gets dragged over when switching from an item to the other:

Line

Do you want me to open a new issue for this?

@MrKai77
Copy link
Owner

MrKai77 commented Nov 29, 2023

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants