Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Erratic behaviour of toolbar's divider line #92

Closed
2 tasks done
Zabriskije opened this issue Nov 29, 2023 · 1 comment · Fixed by #109
Closed
2 tasks done

🐛 Erratic behaviour of toolbar's divider line #92

Zabriskije opened this issue Nov 29, 2023 · 1 comment · Fixed by #109
Assignees
Labels

Comments

@Zabriskije
Copy link
Contributor

Bug Description

The black line under the toolbar gets dragged over when switching between items.

Steps To Reproduce

  1. Open Settings
  2. Switch between toolbar items

Expected Behavior

The black line should remain in its original place.

Actual Behavior

The black line moves over the toolbar items.

Screenshots

Black line bug GIF

MacOS Version

Sonoma 14.1.1 (23B81)

Loop Version

1.0.0-beta.12 (515)

Additional Context

No response

Final Checks

  • My issue title is descriptive
  • This is a single bug (multiple bugs should be reported individually)
@Zabriskije Zabriskije added the Bug label Nov 29, 2023
@MrKai77 MrKai77 self-assigned this Nov 29, 2023
MrKai77 added a commit that referenced this issue Dec 1, 2023
MrKai77 added a commit that referenced this issue Dec 1, 2023
@MrKai77
Copy link
Owner

MrKai77 commented Dec 1, 2023

In your previous issue about the settings window, I said:

So I think that moving away from using the Settings package and making the settings window myself is the way to go.

And due to these issues it's been causing me, I have decided to do this. Here's the latest build, with a settings window that's made in SwiftUI rather than by using the package:
Loop.zip

If you want to follow the settings window's conversion to SwiftUI, I'll most likely post updates in #104 :)

EDIT: Merged!

@MrKai77 MrKai77 linked a pull request Dec 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants