Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Change positions code #1

Open
ayacoo opened this issue Oct 6, 2020 · 0 comments
Open

Proposal: Change positions code #1

ayacoo opened this issue Oct 6, 2020 · 0 comments

Comments

@ayacoo
Copy link

ayacoo commented Oct 6, 2020

getProductStartLine() and getProductEndLine() are private functions and used in getPositions().

The parser exception is already thrown in the getPositions() function. So I would remove this in the private functions and return a 0 in the worst case. getPositions() "loops" from 0 to 0 and throws the ReceiptParseException. So we can test this case with different number of positions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant