Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make datatypes images to have a fixed size #161

Open
walkero-gr opened this issue Nov 15, 2021 · 2 comments
Open

Make datatypes images to have a fixed size #161

walkero-gr opened this issue Nov 15, 2021 · 2 comments

Comments

@walkero-gr
Copy link
Collaborator

There are situations were the displayed image using datatypes is too big. Make it respect the screenshot size set on preferences.

https://eab.abime.net/showpost.php?p=1509026&postcount=208
https://eab.abime.net/showpost.php?p=1509028&postcount=209

@walkero-gr walkero-gr added this to the iGame v2.1 milestone Nov 16, 2021
@coldacid
Copy link
Contributor

If we can resize the image via the datatype system, then we shouldn't need guigfx any longer. As far as I can tell, we're only using guigfx to handle the resizing of the image. However, guigfx does allow us to maintain the aspect ratio of the image for cases where the image aspect ratio and preferential screenshot size aspect ratio are different; we would need any datatypes-based resizing to respect the image aspect ratio.

@coldacid
Copy link
Contributor

Looks like picture.datatype only supports image scaling from v45 onwards. Users of 3.9, 4.x, 3.1.4, and 3.2 will be able to get images scaled to a fixed size via datatypes, but users on 3.0, 3.1, and 3.5 would still need guigfx in order to keep the screenshot/icon images consistent. And this is even without aspect ratio in mind.

@walkero-gr walkero-gr modified the milestones: iGame v2.1, iGame v2.2.0 Jun 4, 2022
@walkero-gr walkero-gr removed this from the iGame v2.2.0 milestone Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants