Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 other doom icons as optional editor icon #49

Closed
heiwiper opened this issue Jun 16, 2021 · 14 comments
Closed

Add 2 other doom icons as optional editor icon #49

heiwiper opened this issue Jun 16, 2021 · 14 comments

Comments

@heiwiper
Copy link

Can you add the 2 doom icons from this repo as editor icons ?


@Mstrodl
Copy link
Owner

Mstrodl commented Jun 16, 2021

@heiwiper Honestly not sure of the merit of wasting two icon slots (discord has a 50 icon cap) on two alternate icons like this...

@heiwiper
Copy link
Author

I didn't know about the icon slots limit, this makes sense.

Is there a way to add a sort of table in the README file or a separate file to provide links to the icons used in case someone wants to have the exact same modes icons except for the editor ?

Thanks for answering feel free to close this issue.

@Mstrodl
Copy link
Owner

Mstrodl commented Jun 16, 2021

@Zulu-Inuoe @heiwiper I actually would like to see a folder or zip with the icons to create an application. If you (Zulu) don't have them, I can definitely write a script to grab them. Maybe we should make a (Discord) team for the app so I can handle these issues and/or PRs as well?

@Zulu-Inuoe
Copy link
Collaborator

@Mstrodl I wasn't aware of teams. I must have missed them last I looked. I created a team and migrated the application to it. Just sent you an invite to it.
I unfortunately do not have all the icons handy, but if you're able to grab them from the application that'd be great.

@Zulu-Inuoe
Copy link
Collaborator

@heiwiper Honestly not sure of the merit of wasting two icon slots (discord has a 50 icon cap) on two alternate icons like this...

@Mstrodl BTW What is your reference for this 50 icon limit? I have looked around and can't find documentation on icon limits, not that I don't believe you. I'd just like to have something definitive to point to

@Mstrodl
Copy link
Owner

Mstrodl commented Jun 17, 2021

@Zulu-Inuoe Wait sorry, I guess I misremembered or it changed recently... Apparently it's 300. In this case I'm not as concerned about it (we appear to be at 48 now according to the API)

@Zulu-Inuoe
Copy link
Collaborator

That's good to hear, but where's that 300 number coming from? My Google-fu is weak

@Mstrodl
Copy link
Owner

Mstrodl commented Jun 17, 2021

@Zulu-Inuoe Look where my cursor is:
image

@Zulu-Inuoe
Copy link
Collaborator

🤦

Thanks

@Mstrodl
Copy link
Owner

Mstrodl commented Jun 17, 2021

Also, I've made a icons folder in the repo with all the icons of the app so hopefully others can recreate the application themselves :)

@heiwiper
Copy link
Author

Also, I've made a icons folder in the repo with all the icons of the app so hopefully others can recreate the application themselves :)

There's apparently a problem concerning the resolution of the images, the minimum assets resolution is required to be 512x512 or higher, I'm not sure whether you can't download original size of assets or they just increased the minimum required resolution recently.

I will be free tomorrow, I can update each logo in the icons folder you've added with the a bigger one (I already have some)

@Mstrodl
Copy link
Owner

Mstrodl commented Jun 17, 2021

@heiwiper oh I see, I was downloading them without the query parameter specifying the size 🤦 I'll fix it :P

@Mstrodl
Copy link
Owner

Mstrodl commented Jun 17, 2021

@heiwiper Check now :P

@heiwiper
Copy link
Author

It's perfect 👌 thank you so much!

I will close the issue since it is now possible to easily add a discord application and use any editor icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants