-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sveltekit annotation #583
sveltekit annotation #583
Conversation
✅ Deploy Preview for documentcloud-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. No major feedback. I've got another follow-up commit with a few style tweaks.
@@ -44,12 +44,11 @@ | |||
overflow: hidden; | |||
text-overflow: ellipsis; | |||
font-family: "Source Sans Pro"; | |||
font-size: 1rem; | |||
font-style: normal; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw you removed the text size in another commit. This is needed to prevent the default browser font-size
for inputs, which is smaller than our body text size. I've added an override in case we need text inputs of different sizes (a title input sized --font-xl
, for example).
Sections and notes. WIP.
Notes are in good shape here and can be reviewed/merged if ready.
Sections are also ready for review.
Closes #561 and #562