Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sveltekit annotation #583

Merged
merged 24 commits into from
Jul 13, 2024
Merged

sveltekit annotation #583

merged 24 commits into from
Jul 13, 2024

Conversation

eyeseast
Copy link
Contributor

@eyeseast eyeseast commented Jun 27, 2024

Sections and notes. WIP.

Notes are in good shape here and can be reviewed/merged if ready.

Sections are also ready for review.

Closes #561 and #562

Copy link

github-actions bot commented Jun 27, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 28.42% 3635 / 12788
🔵 Statements 28.42% 3635 / 12788
🔵 Functions 32.72% 72 / 220
🔵 Branches 52.76% 191 / 362
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/lib/api/documents.ts 95.54% 77.35% 100% 95.54% 75-76, 106-107, 110-111, 136-137, 154-160, 164-165, 199-200, 334-335, 338-339, 399-401
src/lib/api/notes.ts 80.7% 61.11% 83.33% 80.7% 12-27, 33-52, 85-86, 89-90, 129-130, 133-134
src/lib/api/sections.ts 70.78% 42.85% 60% 70.78% 12-31, 40-63, 96-97, 100-101, 140-141, 144-145
src/lib/components/common/Button.svelte 100% 75% 100% 100%
src/lib/components/documents/AnnotationPane.svelte 0% 0% 0% 0% 1-313
src/lib/components/documents/Note.svelte 0% 0% 0% 0% 1-318
src/lib/components/documents/NotesPane.svelte 0% 0% 0% 0% 1-103
src/lib/components/documents/PDF.svelte 0% 0% 0% 0% 1-107
src/lib/components/documents/PDFPage.svelte 0% 0% 0% 0% 1-385
src/lib/components/documents/Page.svelte 0% 0% 0% 0% 1-138
src/lib/components/documents/PageAnnotation.svelte 0% 0% 0% 0% 1-75
src/lib/components/forms/EditData.svelte 0% 0% 0% 0% 1-120
src/lib/components/forms/EditNote.svelte 0% 0% 0% 0% 1-93
src/lib/components/forms/EditSections.svelte 0% 0% 0% 0% 1-261
src/lib/components/inputs/KeyValue.svelte 0% 0% 0% 0% 1-197
src/lib/components/inputs/Number.svelte 0% 0% 0% 0% 1-61
src/lib/components/inputs/Select.svelte 100% 100% 100% 100%
src/lib/components/inputs/Text.svelte 100% 100% 100% 100%
src/lib/utils/api.ts 91.78% 69.23% 100% 91.78% 29-32, 53-54
src/routes/documents/[id]-[slug]/+layout.svelte 0% 0% 0% 0% 1-88
src/routes/documents/[id]-[slug]/+layout.ts 0% 0% 0% 0% 1-46
src/routes/documents/[id]-[slug]/+page.server.ts 0% 0% 0% 0% 1-129
src/routes/documents/[id]-[slug]/+page.svelte 0% 0% 0% 0% 1-199
src/routes/documents/[id]-[slug]/+page.ts 0% 0% 0% 0% 1-51
src/routes/documents/[id]-[slug]/annotate/+page.server.ts 0% 0% 0% 0% 1-99
src/routes/documents/[id]-[slug]/annotate/+page.svelte 0% 0% 0% 0% 1-96
src/routes/documents/[id]-[slug]/annotate/+page.ts 0% 0% 0% 0% 1-13
src/routes/documents/[id]-[slug]/sidebar/Actions.svelte 0% 0% 0% 0% 1-161
src/routes/documents/[id]-[slug]/sidebar/Data.svelte 0% 0% 0% 0% 1-80
src/routes/documents/[id]-[slug]/sidebar/Sections.svelte 0% 0% 0% 0% 1-62
Generated in workflow #200

Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 4e1e7c7
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/669197f94f8a5d00085d919a
😎 Deploy Preview https://deploy-preview-583.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@eyeseast eyeseast requested a review from allanlasser July 8, 2024 14:51
@eyeseast eyeseast marked this pull request as ready for review July 9, 2024 17:34
Copy link
Member

@allanlasser allanlasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. No major feedback. I've got another follow-up commit with a few style tweaks.

@@ -44,12 +44,11 @@
overflow: hidden;
text-overflow: ellipsis;
font-family: "Source Sans Pro";
font-size: 1rem;
font-style: normal;
Copy link
Member

@allanlasser allanlasser Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw you removed the text size in another commit. This is needed to prevent the default browser font-size for inputs, which is smaller than our body text size. I've added an override in case we need text inputs of different sizes (a title input sized --font-xl, for example).

@eyeseast eyeseast merged commit a909078 into sveltekit Jul 13, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants