-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New button group component added #1484
Conversation
It looks cool! |
f9cc075
to
de773e8
Compare
@JonBunator would any public API change in either senario? |
Thanks for your response. Option one would require changes in Option two would not require changes in |
Hmm. @henon do have an opinion on this. My first thoughts are changing button styles might have an impact we will not immediately be aware of. However the button shrinking to content seems like desired and predictable behaviour to me so I might be inclined to try that route and have a good look around the examples to see if it broke any layout. |
Sure mike, I agree. |
|
de773e8
to
2aa1667
Compare
2aa1667
to
cf9986a
Compare
Looking great so far. Usually button group has an optional selection feature too. No selection, exclusive selection, multi-selection. At least I know it from Vuetify like that: https://vuetifyjs.com/en/components/button-groups/. The button group has a two-way bindable hashset of selected indices. Do you want to add that feature + tests also? |
Thanks for your feedback! |
Sounds good, I totally agree. |
Alright, I can start a PR after this PR is merged. That way I can reuse the css classes. |
A new button group component that groups related buttons together. As described in #1249
Tell me what you think :)
Edit:
MudIconButton
andMudToggleIconButton
addedcloses #1249