Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudSelect: Do not fire changed event when the same item is selected again. #1723

Merged
merged 1 commit into from
May 31, 2021
Merged

MudSelect: Do not fire changed event when the same item is selected again. #1723

merged 1 commit into from
May 31, 2021

Conversation

tungi52
Copy link
Contributor

@tungi52 tungi52 commented May 30, 2021

Fix for #1521

SelectedValues.Clear();
SelectedValues.Add(value);
}
BeginValidate();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this line, because in single selection mode the method SetValueAsync already called it once.

@henon
Copy link
Collaborator

henon commented May 30, 2021

Is it possible to derive a test case from the posted tryMB?

@henon henon changed the title Fix selection change when item reselected MudSelect: Do not fire changed event when the same item is selected again. May 31, 2021
@henon henon merged commit ddc0060 into MudBlazor:dev May 31, 2021
@henon henon added this to the 5.0.11 milestone May 31, 2021
@henon
Copy link
Collaborator

henon commented May 31, 2021

Thank you András. Your efforts are much appreciated!

By the way, I like that you tried to encourage the OP to PR. In my experience many will do it, so keep doing it instead of just fixing their problems right away. That way we'll multiply our efforts and maybe even recruit more contributors that way.

@tungi52 tungi52 deleted the select-reselect branch June 16, 2021 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants