MudTable: Added parameter to control column sort direction cycling asc->desc->none vs asc->desc->asc #1737
Conversation
…cending", "None")
|
I guess the tests will succeed if #1736 will be merged. It contains a fix for that. |
| if (state.SortDirection != SortDirection.None && string.IsNullOrWhiteSpace(state.SortLabel)) | ||
| throw new ArgumentException("SortDirection is set but SortLabel is not"); | ||
|
|
There was a problem hiding this comment.
Please remove the ArgumentException. Let's just ignore sorting when the label isn't set, ok?
There was a problem hiding this comment.
Sure. Removed and commited.
But I still believe this test should be enabled after other fixes are applied.
It just doesn't make sense if SortDirection is not "None" but SortLabel is null.
It's something like "sort ascending/descending by nothing".
Actually the test fail is due to the ArgumentException.
But yeah, let's rebase onto dev to see if it makes a difference. |
|
Thanks |
henon
changed the title
Added a property "AllowUnsorted" to MudTable to control sorted state.
When "AllowUnsorted" is set to true (default) the behavior is same as it is now - column sort states change in order "Ascending", "Descending", "None".
But when "AllowUnsorted" is false, then when a column is clicked for sorting, the states loop between "Ascending" and "Descending" so there is always at least one sorted column used.