Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExpansionPanels: Added ExpandAll and CollapseAll methods #3699

Merged
merged 4 commits into from
Jan 11, 2022
Merged

ExpansionPanels: Added ExpandAll and CollapseAll methods #3699

merged 4 commits into from
Jan 11, 2022

Conversation

poteb
Copy link
Contributor

@poteb poteb commented Jan 9, 2022

Description

Added these methods to better control the panel.

How Has This Been Tested?

Added two unit tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@JonBunator JonBunator added needs review enhancement New feature or request labels Jan 10, 2022
@codecov
Copy link

codecov bot commented Jan 10, 2022 •
edited
Loading

Codecov Report

Merging #3699 (e2a633b) into dev (9809564) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3699      +/-   ##
==========================================
+ Coverage   90.49%   90.55%   +0.05%     
==========================================
  Files         332      332              
  Lines       10494    10499       +5     
==========================================
+ Hits         9497     9507      +10     
+ Misses        997      992       -5
Impacted Files Coverage Δ
...ponents/ExpansionPanel/MudExpansionPanels.razor.cs 97.56% <100.00%> (+0.59%) ⬆️
...r/Components/Progress/MudProgressCircular.razor.cs 92.00% <0.00%> (-0.86%) ⬇️
...mponents/ExpansionPanel/MudExpansionPanel.razor.cs 94.64% <0.00%> (+8.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9809564...e2a633b. Read the comment docs.

JonBunator
JonBunator requested changes Jan 10, 2022
View reviewed changes
Copy link
Member

@JonBunator JonBunator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
No, final decision yet if we want to merge it. But nothing speaks against it imo.

src/MudBlazor/Components/ExpansionPanel/MudExpansionPanels.razor.cs Outdated Show resolved Hide resolved
src/MudBlazor/Components/ExpansionPanel/MudExpansionPanels.razor.cs Show resolved Hide resolved
@poteb
Copy link
Contributor Author

poteb commented Jan 10, 2022

I made this change because I need the functionality for a website. I've hacked it for now with reflection, but would rather have a proper way to do this. I also think this is normal and often seen functionality for this kind of control.

@mikes-gh
Copy link
Contributor

If we go ahead with this I vote to fix the naming now before following old misnomers. Forward and obsolete the old CloseAllExcept to CollapseAllExcept and name the new Collapse....

@poteb
Renamed CloseAll to CollapseAll
32214e8 
Fixed test for CollapseAll.
Added CollapseAllExcept and call it from CloseAllExcept, which is now obsolete.
Added test for CollapseAllExcept.
Added InvokeAsync for UpdateAll call in CollapseAllExcept.
@mikes-gh mikes-gh changed the title ExpansionPanels: Added ExpandAll and CloseAll methods ExpansionPanels: Added ExpandAll and CollapseAll methods Jan 10, 2022
@mikes-gh
Copy link
Contributor

@Garderoben @henon For me I can see scenarios where this new API makes sense.

@mikes-gh mikes-gh added API change API that needs approval and removed needs changes labels Jan 10, 2022
@henon
Copy link
Collaborator

henon commented Jan 11, 2022

Yes, I support it. It is useful, no question about it.

@mikes-gh
Copy link
Contributor

I spoke to @Garderoben We will merge this very soon.

@mikes-gh mikes-gh merged commit 0e2aa23 into MudBlazor:dev Jan 11, 2022
@mikes-gh mikes-gh added this to the 6.0.5 milestone Jan 11, 2022
@poteb poteb deleted the MudExpansionPanels_ExpandAll_CloseAll branch January 12, 2022 20:59
@mckaragoz mckaragoz mentioned this pull request Jan 14, 2022
Open
2 tasks
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
@poteb @jammerware
ExpansionPanels: Added ExpandAll and CollapseAll methods (MudBlazor#3699
78c32ab 
)
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
@poteb @jammerware
ExpansionPanels: Added ExpandAll and CollapseAll methods (MudBlazor#3699
d6d22f6 
)
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
@poteb @jammerware
ExpansionPanels: Added ExpandAll and CollapseAll methods (MudBlazor#3699
4a7bda5 
)
jammerware pushed a commit to jammerware/MudBlazor that referenced this pull request Sep 20, 2022
@poteb @jammerware
ExpansionPanels: Added ExpandAll and CollapseAll methods (MudBlazor#3699
1fb1d5a 
)
3dots pushed a commit to 3dots/MudBlazor that referenced this pull request Mar 23, 2023
@poteb @3dots
ExpansionPanels: Added ExpandAll and CollapseAll methods (MudBlazor#3699
8d1ae26 
)
ferraridavide pushed a commit to ferraridavide/MudBlazor that referenced this pull request May 30, 2023
@poteb @ferraridavide
ExpansionPanels: Added ExpandAll and CollapseAll methods (MudBlazor#3699
181370f 
)
ilovepilav pushed a commit to ilovepilav/MudBlazor that referenced this pull request Nov 25, 2023
@poteb @ilovepilav
ExpansionPanels: Added ExpandAll and CollapseAll methods (MudBlazor#3699
0899a7e 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikes-gh mikes-gh mikes-gh left review comments

@JonBunator JonBunator JonBunator approved these changes

Assignees
No one assigned
Labels
API change API that needs approval enhancement New feature or request
Projects
None yet
Milestone
6.0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@poteb @mikes-gh @henon @JonBunator