-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudBaseInput: Make OnBlurred async #6633
Conversation
Doesn't fixes the KeyDown down since the method isn't internal in |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #6633 +/- ##
==========================================
- Coverage 90.63% 90.53% -0.11%
==========================================
Files 399 399
Lines 13587 13613 +26
==========================================
+ Hits 12315 12324 +9
- Misses 1272 1289 +17
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
It seems that my recent change resulted in a breaking change for those who inherit this type and previously used OnBlurred. I take full responsibility for this mistake. I was confused by the use of the word "internal" in the method signature and wrongly assumed that it would be a safe change since I thought the method was only visible within the library. However, it turns out that the method is actually marked as protected internal, which makes it visible to anyone who inherits MudBaseInput. |
Well, the break already happened, and we don't guarantee that protected API won't be changed, so I think no revert is necessary. |
Description
Fixes: #6322
Wasn't catching exception since on blurr wasn't awaited (async void problem)
I believe since OnBlurred was protected internal it's not breaking change to change the signature
How Has This Been Tested?
New unit test + checked visually on https://try.mudblazor.com/snippet/QOwdkmvIplIxkslV
Types of changes
Checklist:
dev
).