Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudFormComponent: Deprecate BeginValidate in favor of Async version #6637

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Apr 12, 2023

Description

This PR #6633 introduced BeginValidateAsync and BeginValidateAfterAsync.
It makes sense to deprecate the old ones, because they are dangerous.
All methods that used them were async which is great and everything is awaited properly now.

How Has This Been Tested?

Unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 64.70% and project coverage change: +0.04 🎉

Comparison is base (1a662ed) 90.48% compared to head (1f6a164) 90.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6637      +/-   ##
==========================================
+ Coverage   90.48%   90.53%   +0.04%     
==========================================
  Files         399      399              
  Lines       13617    13612       -5     
==========================================
+ Hits        12322    12324       +2     
+ Misses       1295     1288       -7     
Impacted Files Coverage Δ
src/MudBlazor/Base/MudFormComponent.cs 78.40% <ø> (-4.93%) ⬇️
src/MudBlazor/Components/DataGrid/Filter.cs 77.96% <0.00%> (ø)
...dBlazor/Components/DataGrid/FilterHeaderCell.razor 37.50% <0.00%> (ø)
src/MudBlazor/Components/DataGrid/HeaderCell.razor 89.65% <ø> (ø)
...rc/MudBlazor/Components/DataGrid/MudDataGrid.razor 88.33% <ø> (ø)
src/MudBlazor/Components/DataGrid/FilterContext.cs 54.54% <25.00%> (-16.89%) ⬇️
...azor/Components/DataGrid/FilterHeaderCell.razor.cs 42.85% <45.45%> (+13.94%) ⬆️
.../MudBlazor/Components/DataGrid/HeaderCell.razor.cs 71.92% <50.00%> (+3.44%) ⬆️
...MudBlazor/Components/DataGrid/MudDataGrid.razor.cs 90.71% <90.00%> (+0.57%) ⬆️
src/MudBlazor/Base/MudBaseInput.cs 87.03% <100.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ScarletKuro ScarletKuro requested a review from henon April 12, 2023 17:04
@henon henon merged commit 50da41d into MudBlazor:dev Apr 12, 2023
3 of 4 checks passed
@henon
Copy link
Collaborator

henon commented Apr 12, 2023

Right, to be removed in v7. Thanks Kuro!

@ScarletKuro ScarletKuro deleted the BeginValidate_obsolete branch April 12, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants