-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudDataGrid: Add FilterVariant Property #8484
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the xml comment
Can you show before and after screenshots how the new visuals look? Thanks |
@henon |
fyi: the tests fail now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks, @dunds-com!
@dunds-com can you fix the tests? It looks related, then we can merge. |
@ScarletKuro @tjscience @henon The test doesn't seem to find the add button in the filters anymore. But it does work when using the method. Maybe setting the variant is causing the button to be rendered with a delay? |
If it is indeed a timing issue as you suspect then you could prove it by waiting for 1 second with |
Adding the delay does not seem to have an effect. |
Do a |
Very strange, technically added property shouldn't have affected anything except the |
Description
MudDataGrid was missing the Variant property, so you could not set it for the filtering.
How Has This Been Tested?
Visually tested using the docs.
Types of changes
Checklist:
dev
).