Chip: Don't apply hover or focus effect if not clickable and allow text selection

[danielchalmers]

Description

• Revives and closes Chip: Fix hover effect occuring when component wasn't interactive (#7243) #7386
• Revives and closes MudChip: Fix hover effect only when interactive #7614

How Has This Been Tested?

visually

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Resolves #7243
Hover before:

hoverbefore.mp4

Hover after:

hoverafter.mp4

Clickable chips remain the same.
Before:

chipsetbefore.mp4

After:

chipsetafter.mp4

Additionally resolves #7420
Before:

selectionbefore.mp4

After:

selectionafter.mp4

It does not interfere with the click effect but allows the user to drag the mouse or double click to select text.

Checklist

• The PR is submitted to the correct branch (dev).
• My code follows the code style of this project.
• I've added relevant tests.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.89%. Comparing base (f70bb9e) to head (bda57e9).
Report is 11 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #8598      +/-   ##
==========================================
+ Coverage   89.78%   89.89%   +0.11%     
==========================================
  Files         411      412       +1     
  Lines       11840    11881      +41     
  Branches     2363     2362       -1     
==========================================
+ Hits        10630    10680      +50     
+ Misses        682      675       -7     
+ Partials      528      526       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[henon]

So clickable chips can not be selected but readonly chips can? I see a ripple in the video where you selected text on the chip. Should we also disable the ripple if the chip is not clickable?

[danielchalmers]

So clickable chips can not be selected but readonly chips can? I see a ripple in the video where you selected text on the chip. Should we also disable the ripple if the chip is not clickable?

I would probably make it work like MUI but I'll leave those decisions to someone else because I don't use the chips enough to have an opinion. I just copied the other PRs.

[henon]

OK, in MUI clickable chips are not selectable but do hover and ripple. Non-clickable are selectable but don't hover and have no ripple. If it is like that now this can be merged.

[danielchalmers]

OK, in MUI clickable chips are not selectable but do hover and ripple. Non-clickable are selectable but don't hover and have no ripple. If it is like that now this can be merged.

I can make it like that if that's the consensus (I agree)

[henon]

Yes, let's do it like that. No need to make it more complicated if we already agree ;)

[danielchalmers]

@henon Done. Please checkout the branch and see if it's what you expect

[henon]

Thanks @danielchalmers