Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudMenu: Disable text selection in activator #8719

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

danielchalmers
Copy link
Contributor

@danielchalmers danielchalmers commented Apr 16, 2024

Description

After #8598 the chip example is now selectable despite being clickable, because the clickable-ness is done on the menu end.
This is especially noticeable when using touch to hold the activator for right clicking.

This resolves it and disables all selection for anything inside the activator, not just chips, to make it a true button.

How Has This Been Tested?

visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)
video1.mp4

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Apr 16, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (28bc599) to head (df44f80).
Report is 64 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8719      +/-   ##
==========================================
+ Coverage   89.82%   90.06%   +0.23%     
==========================================
  Files         412      418       +6     
  Lines       11878    12050     +172     
  Branches     2364     2366       +2     
==========================================
+ Hits        10670    10853     +183     
+ Misses        681      661      -20     
- Partials      527      536       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon changed the title Menu: Disable user selection in activator MudMenu: Disable text selection in activator Apr 18, 2024
@henon henon merged commit 891aa8e into MudBlazor:dev Apr 18, 2024
5 checks passed
@henon
Copy link
Collaborator

henon commented Apr 18, 2024

Thanks Daniel

biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected PR: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants