-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardise the use of Expanded
, Expandable
, IsExpanded
and IsExpandable
#8718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're definitely leaning toward Expanded
over IsExpanded
because it's closer to web standards. See recent PRs: https://github.com/MudBlazor/MudBlazor/pulls?q=is%3Apr+author%3Ahenon+rename
I would do in a separate PR since there are nuances, and it would be easier for me to explain in a smaller PR. |
Expanded
and IsExpanded
Expanded
, Expandable
, IsExpanded
and IsExpandable
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #8718 +/- ##
==========================================
+ Coverage 89.82% 90.09% +0.26%
==========================================
Files 412 419 +7
Lines 11878 12175 +297
Branches 2364 2396 +32
==========================================
+ Hits 10670 10969 +299
+ Misses 681 667 -14
- Partials 527 539 +12 ☔ View full report in Codecov by Sentry. |
@BieleckiLtd thank you for helping! I agree with the proposed changes. This is gonna be conflicted by #8661 which totally overhauls treeview. Hope it won't be too much work to resolve conflicts. Could you prepare a list of changes in the format of
That would help me a lot, when integrating with the migration guide. Finally, because Razor doesn't raise errors with parameters that don't exist, it is necessary to do a There are quite a few other parameters starting with |
I will wait for #8661 to be merged then then pull dev into my branch and resolve conflicts. Setting this as a draft for now.
Ok.
Yes, I did.
That would make sense if we're breaking things. I can work on them on a case by case basis like this PR. Few that I have found are |
MudExpansionPanel: replace |
@BieleckiLtd Thanks, this is big help! |
Added to v7.0.0 Migration Guide #8447 |
…Expandable` (MudBlazor#8718) Co-authored-by: Pawel Bielecki <Pawel.Bielecki2@leoni.com>
MudBlazor currently uses the
Expanded
,Expandable
,IsExpanded
andIsExpandable
properties. This PR aims to standardise the use ofExpanded
andExpandable
.Description
#6131, #8447,
If this PR is approved, the v7 migration guide must also be updated, as this makes a breaking change.
Standardise the use of
IsEnabled
andEnabled
#8764Standardise the use of
ItemDisabled
#8887Standardise the use of
Checked
,CheckedChanged
andCheckable
#8825Standardise the use of
Visible
#8832Standardise the use of
Selected
andSelectedChanged
#8886Standardise the use of
Expanded
,Expandable
,IsExpanded
andIsExpandable
#8718Standardise the use of
Active
#8888Standardise the use of
Open
andOpenChanged
#8891Standardise the use of
Editable
#8892Standardise the use of
Hidden
andHiddenChanged
#8952How Has This Been Tested?
unit | visually
Type of Changes
Checklist
dev
).