-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudSlider: Use ParameterState and generic math #8745
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #8745 +/- ##
==========================================
+ Coverage 89.82% 90.08% +0.25%
==========================================
Files 412 419 +7
Lines 11878 12174 +296
Branches 2364 2396 +32
==========================================
+ Hits 10670 10967 +297
+ Misses 681 667 -14
- Partials 527 540 +13 ☔ View full report in Codecov by Sentry. |
Because of this line and how docs currently work I had no other ideas but implement @henon let me know if there is better ways. |
What's the original purpose of the T class? |
It's used for docs and in some unit tests to construct the component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm from my limited knowledge on this
About class T: |
It suffices for now. We'll solve the problem of class T later for good. |
Thanks, the code looks much better now. Added to v7.0.0 Migration Guide #8447 |
I just thought, would it make sense to add "CultureInfo" parameter in case someone want's the |
Yes, that makes sense. |
Description
Uses ParameterState and generic math so we do not need pesky converters
How Has This Been Tested?
Current unit tests & visual
Type of Changes
Checklist
dev
).