Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudSlider: Add ValueLabelStringFormat, ValueLabelCultureInfo, ValueLabelContent #8760

Merged
merged 4 commits into from
Apr 20, 2024

Conversation

ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented Apr 20, 2024

Description

Follow up PR: #8745 (comment)
gif

How Has This Been Tested?

New bUnit test. Extended value label example

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.09%. Comparing base (28bc599) to head (df1ad45).
Report is 88 commits behind head on dev.

Files Patch % Lines
src/MudBlazor/Components/Slider/MudSlider.razor 66.66% 0 Missing and 1 partial ⚠️
src/MudBlazor/Components/Slider/MudSlider.razor.cs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8760      +/-   ##
==========================================
+ Coverage   89.82%   90.09%   +0.26%     
==========================================
  Files         412      419       +7     
  Lines       11878    12178     +300     
  Branches     2364     2397      +33     
==========================================
+ Hits        10670    10972     +302     
+ Misses        681      667      -14     
- Partials      527      539      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon
Copy link
Collaborator

henon commented Apr 20, 2024

Please for good measure also add a ValueLabelContent render fragment or soon we'll have a flurry of PRs wanting to add color, typo, etc etc

@henon
Copy link
Collaborator

henon commented Apr 20, 2024

I love the example by the way

@ScarletKuro
Copy link
Member Author

ScarletKuro commented Apr 20, 2024

Please for good measure also add a ValueLabelContent render fragment or soon we'll have a flurry of PRs wanting to add color, typo, etc etc

Added ValueLabelContent.
Let me know if I should remove the value context from the RenderFragment, but then they should use two way binding to get this information.
Also, the mud-slider-value-label applying some background and text transformation, if we want that gone for the ValueLabelContent I would need @danielchalmers help.

@henon
Copy link
Collaborator

henon commented Apr 20, 2024

No it is fine with the context. And the content can always override the styles of the containing div if they need to by applying their own style

@ScarletKuro ScarletKuro changed the title MudSlider: Add ValueLabelStringFormat and ValueLabelCultureInfo MudSlider: Add ValueLabelStringFormat, ValueLabelCultureInfo, ValueLabelContent Apr 20, 2024
@ScarletKuro ScarletKuro merged commit 184697b into MudBlazor:dev Apr 20, 2024
3 of 4 checks passed
@ScarletKuro ScarletKuro deleted the slider_culture branch April 20, 2024 19:47
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants