Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudRating: Use ParameterState framework #8877

Merged
merged 2 commits into from
May 5, 2024

Conversation

ScarletKuro
Copy link
Member

Description

Get rid of BL0007
There shouldn't be any breaking change as the method signature was changed for internal / private stuff.

How Has This Been Tested?

Visually, existing tests pass

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@ScarletKuro ScarletKuro requested a review from henon May 4, 2024 23:51
@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels May 4, 2024
Copy link

codecov bot commented May 4, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.07%. Comparing base (28bc599) to head (d96cfd9).
Report is 144 commits behind head on dev.

Files Patch % Lines
...MudBlazor/Components/Rating/MudRatingItem.razor.cs 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8877      +/-   ##
==========================================
+ Coverage   89.82%   90.07%   +0.24%     
==========================================
  Files         412      421       +9     
  Lines       11878    12283     +405     
  Branches     2364     2425      +61     
==========================================
+ Hits        10670    11064     +394     
+ Misses        681      669      -12     
- Partials      527      550      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon merged commit 05bea86 into MudBlazor:dev May 5, 2024
4 checks passed
@henon
Copy link
Collaborator

henon commented May 5, 2024

Thanks Artyom!

@ScarletKuro ScarletKuro deleted the rating_parameter branch May 5, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants