Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudRating: make HandleKeyDown async Task #8883

Merged
merged 3 commits into from
May 5, 2024
Merged

Conversation

ScarletKuro
Copy link
Member

@ScarletKuro ScarletKuro commented May 5, 2024

Description

Follow up for #8877

I missed it since I thought the HandleKeyDown is done via key interceptor therefore it cannot be a Task for now, but it's coming from onkeydown.

How Has This Been Tested?

Visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels May 5, 2024
@ScarletKuro ScarletKuro requested a review from henon May 5, 2024 17:49
Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (28bc599) to head (6de7fc4).
Report is 149 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8883      +/-   ##
==========================================
+ Coverage   89.82%   90.20%   +0.37%     
==========================================
  Files         412      423      +11     
  Lines       11878    12274     +396     
  Branches     2364     2407      +43     
==========================================
+ Hits        10670    11072     +402     
+ Misses        681      668      -13     
- Partials      527      534       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro marked this pull request as draft May 5, 2024 17:54
@ScarletKuro
Copy link
Member Author

ScarletKuro commented May 5, 2024

Will fix some stale comp.FindAll I see in tests and open it back, it's not necessary but to not come back to it just in case it will matter one day.
Btw, there is apparently enableAutoRefresh (default false) overload in FindAll("li", enableAutoRefresh: true); but I guess using lambda is just easier and we already started this function practice.

@ScarletKuro ScarletKuro marked this pull request as ready for review May 5, 2024 18:01
@ScarletKuro
Copy link
Member Author

ready

@henon henon merged commit 7d05d6f into MudBlazor:dev May 5, 2024
4 checks passed
@ScarletKuro ScarletKuro deleted the rating_fix branch May 6, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants