Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog: Fix possible deadlock #8964

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

ScarletKuro
Copy link
Member

Description

Possible fix to #8961?
According to Async Guidance it always preferable to create TaskCompletionSource with TaskCreationOptions.RunContinuationsAsynchronously overload: https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md#always-create-taskcompletionsourcet-with-taskcreationoptionsruncontinuationsasynchronously
Also similar thing was done in Blazored/Modal: Blazored/Modal#408

How Has This Been Tested?

Would be nice to have a bUnit test, but I don't have any example that runs into that problem.

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.48%. Comparing base (28bc599) to head (d612622).
Report is 193 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8964      +/-   ##
==========================================
+ Coverage   89.82%   90.48%   +0.65%     
==========================================
  Files         412      419       +7     
  Lines       11878    12211     +333     
  Branches     2364     2385      +21     
==========================================
+ Hits        10670    11049     +379     
+ Misses        681      627      -54     
- Partials      527      535       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro merged commit 228cebe into MudBlazor:dev May 13, 2024
5 checks passed
@ScarletKuro ScarletKuro deleted the dialog_fix branch May 13, 2024 22:41
danielchalmers added a commit to danielchalmers/MudBlazor that referenced this pull request May 21, 2024
ScarletKuro added a commit that referenced this pull request May 25, 2024
Co-authored-by: Artyom M <artem.melnikov@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant