Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation: Update Add font and sytle references section #8969

Merged
merged 1 commit into from
May 14, 2024

Conversation

Qwertyluk
Copy link
Contributor

Description

Closes #8947

How Has This Been Tested?

Visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added docs Related to docs PR: needs review labels May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (28bc599) to head (3cd6343).
Report is 199 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8969      +/-   ##
==========================================
+ Coverage   89.82%   90.47%   +0.64%     
==========================================
  Files         412      420       +8     
  Lines       11878    12210     +332     
  Branches     2364     2385      +21     
==========================================
+ Hits        10670    11047     +377     
+ Misses        681      628      -53     
- Partials      527      535       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro
Copy link
Member

@jperson2000

Copy link
Contributor

@danielchalmers danielchalmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use App.razor 👍

@henon henon merged commit 3fdc056 into MudBlazor:dev May 14, 2024
5 checks passed
Copy link
Sponsor Contributor

@jperson2000 jperson2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Older .NET 6 Blazor Server uses _Layout.cshtml and .NET 6 WebAssembly uses _Host.cshtml. .NET 8 (and 7?) uses App.razor, in case we want to make this into tabs per framework.

@henon
Copy link
Collaborator

henon commented May 14, 2024

We dropped .net6 support in v7

@Qwertyluk
Copy link
Contributor Author

Qwertyluk commented May 14, 2024

Looks good, thanks! Older .NET 6 Blazor Server uses _Layout.cshtml and .NET 6 WebAssembly uses _Host.cshtml. .NET 8 (and 7?) uses App.razor, in case we want to make this into tabs per framework.

Whether _Host.cshtml or App.razor is used depends on the template rather then .NET version.
Blazor Server Applications utilize _Host.cshtml, whereas Blazor Web Applications use App.razor.
It's worth noting that you can still have a Blazor Server Application (_Host.cshtml) in .NET 8 but Blazor Web Application (App.razor) is accessible only for .NET 8.

@henon
Copy link
Collaborator

henon commented May 14, 2024

OK, so we actually need tabs with the different setups

@jperson2000
Copy link
Sponsor Contributor

jperson2000 commented May 14, 2024

Whether _Host.cshtml or App.razor is used depends on the template rather then .NET version. Blazor Server Applications utilize _Host.cshtml, whereas Blazor Web Applications use App.razor. It's worth noting that you can still have a Blazor Server Application (_Host.cshtml) in .NET 8 but Blazor Web Application (App.razor) is accessible only for .NET 8.

Thanks for the clarification! If you're willing to add the options as tabs in a new PR, here's a code snippet you can work from which would do the trick.

@ScarletKuro
Copy link
Member

Don't forget that standalone WASM application (Not Web App) is also a thing and the template also exist in the .net8.
It's using App.razor as well.

@Qwertyluk
Copy link
Contributor Author

Okay, I'll gather everything and create a new PR with tabs

@Qwertyluk
Copy link
Contributor Author

Qwertyluk commented May 15, 2024

Whether _Host.cshtml or App.razor is used depends on the template rather then .NET version. Blazor Server Applications utilize _Host.cshtml, whereas Blazor Web Applications use App.razor. It's worth noting that you can still have a Blazor Server Application (_Host.cshtml) in .NET 8 but Blazor Web Application (App.razor) is accessible only for .NET 8.

Thanks for the clarification! If you're willing to add the options as tabs in a new PR, here's a code snippet you can work from which would do the trick.

I've started working on that, but I'm a bit confused about how to implement it using tabs.
The provided code snippet is somewhat different because it shows an example where the code varies depending on the application type.
But in this case, the code is the same, but the file names where it should be added vary depending on the application type.
Should I use the file names as tab names, or do you have a different suggestion?

@dennisrahmen
Copy link
Contributor

Don't forget that standalone WASM application (Not Web App) is also a thing and the template also exist in the .net8.

It's using App.razor as well.

Actually the Blazor WASM standalone version has the HTML in the index.html under "wwwroot" so the links to css and js need to be added there.

But the providers like MudPopoverProvider need to be added to the App.razor file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation - installation page is outdated
6 participants