DPI Awareness/Scaling Issues (Win10) #800
Comments
|
Could you attach screenshots? I don't think any developers have a 4K On Sat, 24 Dec 2016 11:45 am Colin Gannon, wrote:
Launchpad Details: #LPC Vadim Peretokin - 2016-12-24 02:26:40 +0000 |
|
Sure - just uploaded screenshots of the Sessions screen as an example. You can see the scaling issue where text is being cut off and form fields are generally smaller/too short. This is evident throughout the app and totally messes up Geyser elements. This may be easily fixed by passing the following option to ./mudlet.exe: OR via the creation of an ini-style qt.conf file in the Mudlet directory (default: C:\Program Files (x86)\mudlet-3.0.0-iota) with the following contents: This tells Qt to let Windows know the app doesn't know how to scale if given a non-standard DPI ratio and lets windows automagically scale the app. The former solution is probably best. I tried re-building Mudlet with the AA_EnableHighDpiScaling attribute set, but I can't find the proper spot (QApplication constructor?) in order to set the attribute. The qt.conf solution also did the trick easily enough and isn't too hacky so I didn't continue investigating. Launchpad Details: #LPC Colin Gannon - 2016-12-25 19:10:16 +0000 Edited: 2018/01/25 by SlySven to include images from original Luanchpad topic:
Mudlet with qt.conf to turn off dpi-awareness and let Windows handle scaling.: |
|
Hm... I don't like how either look, though setting up the autoscaling On Mon, Dec 26, 2016 at 5:20 AM Colin Gannon wrote:
Launchpad Details: #LPC Vadim Peretokin - 2016-12-26 03:40:27 +0000 |
|
Agreed. I've experimented a little further as Qt offers a bunch of ways to handle this. Solution A: Set QT_AUTO_SCREEN_SCALE_FACTOR=1 which scales both the fonts and forms nicely [See attachment]. This is equivalent to adding QApplication::setAttribute(Qt::AA_EnableHighDpiScaling) where the QApplication object is constructed (where should this be in Mudlet? I've tried a number of logical points like line 137 in /src/main.cpp but after building on Win10, it didn't seem set. Solution B: Using qt.conf or -platform windows:dpiawareness=0 is hacky and doesn't scale fonts correctly (forms are good, though). Solution C: Set a static scaling value. (QT_SCALING_FACTOR environment variable or equivalent QApplication attribute) We absolutely wouldn't want to set a static scaling value - we want Qt to query Windows for the scaling factor and use that multiplier (looks like solution A does this). I'm not a Qt expert, so you (Vadim) or someone else can point me in the right direction on where to set the AA_EnableHighDpiScaling attr (solution A), I'd be more than happy to build it, test it and submit a PR. Thanks, Colin Launchpad Details: #LPC Colin Gannon - 2016-12-27 20:53:58 +0000 |
|
Haven't forgotten about this - just busy working on the 3.0 release. Will revisit this right after. Launchpad Details: #LPC Vadim Peretokin - 2017-03-04 13:10:03 +0000 |
|
Colin, you can add the ::setAttribute call to https://github.com/Mudlet/Mudlet/blob/release_30/src/main.cpp#L113 - between line 112 and 113 (after the else and before the #ifdef). Let me know how you go - I haven't got a HiDPI screen to test with myself. Launchpad Details: #LPC Vadim Peretokin - 2017-03-05 20:55:01 +0000 |
|
Sure thing. Will test tonight or tomorrow night. I've since migrated to a Mac as my primary dev box so I'll have to get my -Colin On Mar 5, 2017 4:00 PM, "Vadim Peretokin" wrote:
Launchpad Details: #LPC Colin Gannon - 2017-03-05 21:06:25 +0000 |
|
Does this "fix" require at least a certain Qt 5.x version - remember the code has to compile for all versions back to Qt 5.0.2 - even if we resort to "#if defined" or "#if QT_VERSION > 0x05mmpp" preprocessor directives. OTOH Someone with a real MacOs development platform will be a major plus for the Mudlet project - is there anyway we can drag you aboard Colin? 8-) Launchpad Details: #LPC Stephen Lyons - 2017-03-05 21:17:05 +0000 |
|
Awesome. Well, Mudlet compiles on macOS too, I'd you kept the monitor On Sun, 5 Mar 2017 10:15 pm Colin Gannon, wrote:
Launchpad Details: #LPC Vadim Peretokin - 2017-03-05 22:11:24 +0000 |
|
Travis will tell us if it's a problem :) On Sun, 5 Mar 2017 10:25 pm Stephen Lyons, wrote:
Launchpad Details: #LPC Vadim Peretokin - 2017-03-05 22:11:48 +0000 |
|
Another thing I remembered is that our consoles aren't HiDPI aware. On macOS no option is needed to make Qt scale properly, but you'll see that the main console is not crisp: http://cl.ly/image/3a3B3t0Y3O1t http://cl.ly/image/320v3M2J1H2h So the above solution will only get us halfway there I think. Launchpad Details: #LPC Vadim Peretokin - 2017-03-06 07:03:11 +0000 Edited: 2018/01/25 by SlySven to include images directly |
Um, Mudlet is a QWidget rather than a QML application - does that mean that the given fix option is not applicable‽ Launchpad Details: #LPC Stephen Lyons - 2017-03-06 11:26:41 +0000 |
|
Why wouldn't it? Colin has already demonstrated in a screenshot: https://bugs.launchpad.net/mudlet/+bug/1652413/+attachment/4797276/+files/wenvvar.PNG Launchpad Details: #LPC Vadim Peretokin - 2017-03-06 11:37:30 +0000 |
|
@colin: any update on this? On Mon, Mar 6, 2017 at 12:51 PM Vadim Peretokin
Launchpad Details: #LPC Vadim Peretokin - 2017-03-12 05:42:20 +0000 |
|
I should have some time tomorrow as there's some nasty weather headed my Are you looking to get this in for the 3.0 release? Also, in response to Not to split this thread/conflate issues, but what's the specific need for Thanks, Colin On Mar 12, 2017 12:50 AM, "Vadim Peretokin" wrote:
Launchpad Details: #LPC Colin Gannon - 2017-03-13 12:39:30 +0000 |
|
Nah don't have to rush for 3.0, that one is canned for any new features. Let me know how you go with the HiDPI option and if'd like immediate help, On Mon, Mar 13, 2017 at 1:51 PM Colin Gannon wrote:
Launchpad Details: #LPC Vadim Peretokin - 2017-03-13 13:48:45 +0000 |
|
Another thing to look out for, as reported on Mudlet forums (http://forums.mudlet.org/viewtopic.php?f=5&t=18440&p=38972#p38972) this is how the Script editor renders on a 2560 by 1440 display on Plasma 5.9. Launchpad Details: #LPC Vadim Peretokin - 2017-03-21 09:18:08 +0000 |
|
I'd like to report the same scaling issues on my QHD display (3200 x 1800) on Ubuntu 16.04. Attached are two screenshots showing how small the interface is. I recently had the same issue with kdenlive, but upon updating to the version on their PPA, it solved the issue. I assume they made some changes in their Qt code to support hidpi now that Qt supports it. Hopefully Mudlet can do the same?
|
|
If you could find out what changes they did, that'd be a big help - we're not yet sure on the solution. |
|
@crouthamela could you redo the screenshots using this version please? You'll need to make it executable before being able to run it. |
|
Also, where did you install Mudlet from to get the original screenshot? The generic Linux installer, which uses a more modern version of Qt compared to PPA, renders it ok:
It's tiny but it is scaled correctly. |
|
@vadi2 The original screenshots from me were from 3.0.0 available through the Ubuntu PPA on the Mudlet download page. The AppImage link you sent me resolves the primary scaling issue, although the text in the main area is now very blocky and blurry. Attached screenshots are using the default font, size 12. First one is with anti-aliasing on, the second with it off.
|
|
Ah pff that's just the oldschool MUD effect. Thanks for the screenshots, this information is super helpful, will look at this more. What are your Ubuntu display scaling settings at? |
|
Haha. Display scaling is set to 2. Thanks for working on this, I've noticed a lot of Linux apps have these same UI scaling issues as they get dragged into this whole modern "retina display" thing. |
|
Reporting that I have similar/same issues as @crouthamela does with most recent GNOME 3 and a 4K monitor, QT_SCALE_FACTOR=2. |
|
Haven't got the bandwidth to be investigating it right now, it's especially difficult as I'm lacking a 4K display as well. I hope someone with one will be able to help out the project. |
|
@crouthamela @cmr what if you use QT_AUTO_SCREEN_SCALE_FACTOR=1 - do you still get the blurry main display? |
|
@vadi2 I do, yes. I hope to be able to have some time to try and debug this over the weekend. |
|
3.1 seems to run fine on Windows HiDPI: https://us.v-cdn.net/5020142/uploads/editor/ca/a6shyqg32s6z.png |
|
Another tip, put everything into layouts: https://forum.qt.io/topic/80445/dpi-problems/7 |
|
Is there a general update on the progress of this issue somewhere? I'm a new user on a Surface Pro 4, and while the basic UI works pretty well, there are still some annoying issues in the various editor windows. Examples: |
|
Try 3.4 released just today - the first screenshot might be fixed. I'm not sure about the second one! |
|
Yeah I recognise that I have been hacking around in those areas recently (so that the different Mudlet item "Types" all use "Name:" (rather than "name:" or "Alias name:") and "Command:" (rather than "Substitution:" or ""send plain text:" in the samples you how tried) - so I can tell you are not using the most recently put together stuff. OTOH If I have fixed the issue it will be serendipity rather than by design... |
|
I think the default is DPI unaware, so that Windows 10 is already treating Mudlet as non-DPI aware and auto scaling it, which is why it looks okay, but not awesome. |
|
.... and I just read the Qt documentation, and I'm wrong. It's Per-system/Per-monitor DPI aware. |
Breakpad now uses features from C++17: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3954471 We should make this explicit via the `breakpad_client` target requirements. This change only creates a lower bound because, for compilers that support only parts of C++17, the build will not necessarily complain. For instance, `breakpad` uses `static_assert()` without a second message parameter, which was added with https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n3928.pdf, which not all compilers will support that accept the C++17 standard (e.g., GCC only supports it starting from version 6). The issue was initially raised here: getsentry/sentry-native#798 (reply in thread)
Summary:
Mudlet exhibits behavior associated with static size values (in pixels) in the Qt GUI widgets rather than using relative values. Additionally, the application does not specify DPI awareness such that Qt autoscales the application using the native Windows display APIs.* As such, the UI is, while usable, not properly rendered which breaks third-party UI add-ons produced by the community.
*More info here: http://doc.qt.io/qt-5/highdpi.html
Recommended remediation (up for discussion!):
While an effort to convert Mudlet's QML to relative values would be the "right" fix, the autoscaling provided by Qt 5.6+ and Windows 8.1+ allow for one of the following:
The addition of a qt.conf directive to specify an equivalent of the following (passed at runtime, instructs Windows to treat the application as non-DPI aware and to scale it automatically):
-platform windows:dpiawareness=0
OR
The addition of the following property setter for Windows builds to achieve the same goal as option #1:
QGuiApplication::setAttribute(Qt::AA_EnableHighDpiScaling);
Steps to reproduce:
Run the application on a High DPI Windows 10 machine such as a Microsoft Surface or 4K display with scaling enabled and set to a value other than 100%. Observe the UI scaling issues in the splash frame and Connections frame - particularly cut off text and oddly shaped fields/tiny small icons.
I have tested the -platform windows:dpiawareness=0 solution and it's working with Mudlet3-iota built against Qt5.6 on Windows 10 following the wiki instructions. I am building and testing the second (probably preferable) fix.
Launchpad Details: #LP1652413 Colin Gannon - 2016-12-24 01:38:31 +0000
The text was updated successfully, but these errors were encountered: