Add Clessidra as a default MUD #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there! Thanks for helping Mudlet improve. 🌟 You can directly test the changes here:
No need to install anything - just unzip and run. |
SlySven
reviewed
Apr 8, 2019
| @@ -718,6 +718,15 @@ QString dlgConnectionProfiles::getDescription(const QString& hostUrl, const quin | |||
| * dar forma a tu legado, forjar maravillas olvidadas para ti -o tus aliados- y luchar por fe, gloria o dinero. | |||
| * -- end translation -- | |||
| */ | |||
| } else if (hostUrl == QStringLiteral("mud.clessidra.it")) { | |||
| return QStringLiteral( | |||
| "Clessidra is the first all italian MUD ever created! On Clessidra you may find only original Areas, all in italian! Many features make Clessidra one of the best, or the best, MUD in Italy : Advanced travel mode, fight one to one versus your friend, or enemy, The Arena and its fight, the Mortal Challenge, the intelligent MOBs and their Quest and fighting style, a random automatic mission assignament and for you and your friends you must try the advanced Clan system that allows wars and conquest. A mercenary system to help playing when few players are online, a crafting system to create special object and a graphical user interface to help newbie and expert players have a better experince. A MUD that evolves with new challenge, new rules, new skills!"); | |||
There was a problem hiding this comment.
Actually it makes more sense to have the Italian text here - as the people who will want to play it will be the ones who understand it.
We ought to do the same for the Spanish "Reinos de Leyenda" MUD as well...
|
💡 At some stage in the near future it might be worth while adding a language used indicator to the predefined MUDs (perhaps a small black on white two or two_TWO letter code in the top right corner of the icon)... |
SlySven
approved these changes
Apr 8, 2019
SlySven
added a commit
to SlySven/Mudlet
that referenced
this pull request
Jul 10, 2022
Following the inclusion of "Mud.ren" with its Chinese description text (in Mudlet#6140), I felt it was appropriate to put in the native language texts for a Spanish and an Italian MUD who have already provided us with the text to use but which we hadn't so far. This will address points which I made about this in: Mudlet#1505 and Mudlet#2502 (comment) respectively... I have cleaned up the texts involved for all the descriptions so that they are all wrapped in our `qsl(`...`)` wrapper and the host URLs that are used to identify which one to use are all wrapped in `QLatin1String(`...`)` as they should all be ASCII (as they are all OS compatible file names as well) and there is a `QLatin1String::operator==()` method for them. In passing I have also "fixed" the "website" entries for the Spanish MUD as it is appropriate for them to be in Spanish rather than English as they are not URLs but HTTP-like `<a href="xxxx">`...``</a>` entries. I propose to follow this PR with another one to move the description data to the same place as all the other data about the predefined MUDs (the container defined in the `./src/mudlet.h` file: `(inline static const OrderedMap<QString, GameDetails>) mudlet::scmDefaultGames`) Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
SlySven
added a commit
that referenced
this pull request
Jul 31, 2022
…DS (#6143) Following the inclusion of "Mud.ren" with its Chinese description text (in #6140), I felt it was appropriate to put in the native language texts for a Spanish and an Italian MUD who have already provided us with the text to use but which we hadn't so far. This will address points which I made about this in: #1505 and #2502 (comment) respectively... I have cleaned up the texts involved for all the descriptions so that they are all wrapped in our `qsl(`...`)` wrapper and the host URLs that are used to identify which one to use are all wrapped in `QLatin1String(`...`)` as they should all be ASCII (as they are all OS compatible file names as well) and there is a `QLatin1String::operator==()` method for them. In passing I have also "fixed" the "website" entries for the Spanish MUD as it is appropriate for them to be in Spanish rather than English as they are not URLs but HTTP-like `<a href="xxxx">`...``</a>` entries. Revised taking into account @Kebap 's point that we call them "(Gg)ame(s)" rather than MUD(s)... Signed-off-by: Stephen Lyons <slysven@virginmedia.com> Co-authored-by: Kebap <kebap_spam@gmx.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Add Clessidra as a default MUD
Motivation for adding to Mudlet
They've fulfilled https://wiki.mudlet.org/w/Listing_Your_MUD and have an awesome Mudlet UI!
Other info (issues closed, discussion etc)