Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastucture: fix packaging in Linux builds #6013

Merged
merged 12 commits into from
Mar 19, 2022

Conversation

vadi2
Copy link
Member

@vadi2 vadi2 commented Mar 16, 2022

Brief overview of PR changes/additions

Install latest Luarocks from an action, since the version available in apt is too old to be used with Github.

Motivation for adding to Mudlet

So we can have Linux builds again.

@add-deployment-links
Copy link

add-deployment-links bot commented Mar 16, 2022

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@mudlet-machine-account mudlet-machine-account added this to the 4.16.0 milestone Mar 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2022

Messages
✔️

PR type: Infrastructure

Generated by 🚫 dangerJS against 7088b52

@vadi2 vadi2 marked this pull request as ready for review March 19, 2022 12:06
@vadi2 vadi2 requested a review from a team as a code owner March 19, 2022 12:06
Copy link
Member

@demonnic demonnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vadi2 vadi2 merged commit 79bbc51 into development Mar 19, 2022
@vadi2 vadi2 deleted the install-luarocks-from-action branch March 19, 2022 14:05
vadi2 added a commit that referenced this pull request Apr 2, 2022
#### Brief overview of PR changes/additions
Install Luarocks 3.8.0 to compile with Github's security policy.
#### Motivation for adding to Mudlet
CI builds on Windows work again.
#### Other info (issues closed, discussion etc)
#6013 fixed it for Ubuntu builds, this fixes it for Windows builds.

Requires #6027 to be merged first in order to work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants