Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure: fix Luarocks on Windows #6028

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

vadi2
Copy link
Member

@vadi2 vadi2 commented Apr 2, 2022

Brief overview of PR changes/additions

Install Luarocks 3.8.0 to compile with Github's security policy.

Motivation for adding to Mudlet

CI builds on Windows work again.

Other info (issues closed, discussion etc)

#6013 fixed it for Ubuntu builds, this fixes it for Windows builds.

Requires #6027 to be merged first in order to work.

@vadi2 vadi2 requested a review from a team as a code owner April 2, 2022 11:52
@add-deployment-links
Copy link

add-deployment-links bot commented Apr 2, 2022

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@mudlet-machine-account mudlet-machine-account added this to the 4.16.0 milestone Apr 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

Messages
✔️

PR type: Infrastructure

Generated by 🚫 dangerJS against 4bb620c

@vadi2 vadi2 enabled auto-merge (squash) April 2, 2022 16:34
@vadi2 vadi2 disabled auto-merge April 2, 2022 17:46
@vadi2 vadi2 merged commit 8f942c9 into development Apr 2, 2022
@vadi2 vadi2 deleted the install-luarocks-3.8.0-windows branch April 2, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants