Fix: fix getMainWindowSize values if console tab is not in focus (hidden) #6438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use old values if console is hidden
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
SlySven
reviewed
Nov 23, 2022
|
@gesslar does this work better for your UI? |
|
Does the link to the PTB above always point to the latest commit build? I can dl it and try it. |
|
Yep, you are good to go -
|
|
I'm testing it now to see what happens when I switch back. |
|
Seems to be working! 👍 |
vadi2
approved these changes
Nov 24, 2022
Kebap
changed the title
add suggested change Co-authored-by: Vadim Peretokin <vperetokin@hey.com>
SlySven
added a commit
to SlySven/Mudlet
that referenced
this pull request
Nov 25, 2022
The lua code put in there was trying to use this new event to force a redraw of Geyser widgets when a profile hidden during multi-playing when multi-view was not in use. This was an attempt to solve Mudlet#5960. However it seems the problem was with faulty reading of the `TMainConsole` size whilst it was being shown. That appears to have been solved by a different PR: Mudlet#6438 that is waiting to be merged into the code-base. As such the tweaking with the lua file will not be required. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Trying to fix wrong getMainWindowSize values if console is hidden,
for example when another console tab is in focus
Motivation for adding to Mudlet
Other info (issues closed, discussion etc)
should fix #5960