Infra: Repair name of Linux PTB version #7221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Brief overview of PR changes/additions I made an error in Mudlet#7160 as I thought that something that looked like a function call returned a value that could be assigned to something with a `set(...)` but CMake doesn't work like that, instead one has to provide a variable to recieve the value as the last argument to a `string(...)` function. 馃檮 #### Motivation for adding to Mudlet Fix an error that causes cruft to appear, at least, in the version number on the first tab of the "About Mudlet" dialogue. #### Other info (issues closed, discussion etc) This should close Mudlet#7220. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 馃専 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Kebap
changed the title
|
Renamed to actually reflect contents |
vadi2
approved these changes
May 12, 2024
|
I wonder if I get a badge for turning this around quickly? 馃榾 |
|
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
I made an error in #7160 as I thought that something that looked like a function call returned a value that could be assigned to something with a
set(...)but CMake doesn't work like that, instead one has to provide a variable to recieve the value as the last argument to astring(...)function. 馃檮Motivation for adding to Mudlet
Fix an error that causes cruft to appear, at least, in the version number on the first tab of the "About Mudlet" dialogue.
Other info (issues closed, discussion etc)
This should close #7220.